Fix bool/int confusion

nikic · nikic · commit f5c4699b5605 · 2020-03-02T18:29:23.000+01:00
diff --git a/ext/tokenizer/tokenizer.c b/ext/tokenizer/tokenizer.c
@@ -116,7 +116,7 @@ PHP_METHOD(PhpToken, getAll)
 	ZEND_PARSE_PARAMETERS_END();
 
 	token_class = zend_get_called_scope(execute_data);
-	if (tokenize_common(return_value, source, flags, token_class) == FAILURE) {
+	if (!tokenize_common(return_value, source, flags, token_class)) {
 		RETURN_THROWS();
 	}
 }
@@ -494,7 +494,7 @@ PHP_FUNCTION(token_get_all)
 		Z_PARAM_LONG(flags)
 	ZEND_PARSE_PARAMETERS_END();
 
-	if (tokenize_common(return_value, source, flags, /* token_class */ NULL) == FAILURE) {
+	if (!tokenize_common(return_value, source, flags, /* token_class */ NULL)) {
 		RETURN_THROWS();
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ PHP_METHOD(PhpToken, getAll)`
`116`	`116`	`ZEND_PARSE_PARAMETERS_END();`
`117`	`117`
`118`	`118`	`token_class = zend_get_called_scope(execute_data);`
`119`		`- if (tokenize_common(return_value, source, flags, token_class) == FAILURE) {`
	`119`	`+ if (!tokenize_common(return_value, source, flags, token_class)) {`
`120`	`120`	`RETURN_THROWS();`
`121`	`121`	`}`
`122`	`122`	`}`
`@@ -494,7 +494,7 @@ PHP_FUNCTION(token_get_all)`
`494`	`494`	`Z_PARAM_LONG(flags)`
`495`	`495`	`ZEND_PARSE_PARAMETERS_END();`
`496`	`496`
`497`		`- if (tokenize_common(return_value, source, flags, /* token_class */ NULL) == FAILURE) {`
	`497`	`+ if (!tokenize_common(return_value, source, flags, /* token_class */ NULL)) {`
`498`	`498`	`RETURN_THROWS();`
`499`	`499`	`}`
`500`	`500`	`}`