Fix technically incorrect sizeof

nielsdos · nielsdos · commit fe3bea090e59 · 2025-06-09T22:05:09.000+02:00
This doesn't actually matter because both `*sal` and `**sal` are pointer sized, but this makes analysers happy. Fixes bug #68866. Closes GH-18816.
diff --git a/main/network.c b/main/network.c
@@ -227,7 +227,7 @@ PHPAPI int php_network_getaddresses(const char *host, int socktype, struct socka
 	for (n = 1; (sai = sai->ai_next) != NULL; n++)
 		;
 
-	*sal = safe_emalloc((n + 1), sizeof(*sal), 0);
+	*sal = safe_emalloc((n + 1), sizeof(**sal), 0);
 	sai = res;
 	sap = *sal;
 
@@ -266,7 +266,7 @@ PHPAPI int php_network_getaddresses(const char *host, int socktype, struct socka
 		in = *((struct in_addr *) host_info->h_addr);
 	}
 
-	*sal = safe_emalloc(2, sizeof(*sal), 0);
+	*sal = safe_emalloc(2, sizeof(**sal), 0);
 	sap = *sal;
 	*sap = emalloc(sizeof(struct sockaddr_in));
 	(*sap)->sa_family = AF_INET;

Original file line number	Diff line number	Diff line change
`@@ -227,7 +227,7 @@ PHPAPI int php_network_getaddresses(const char *host, int socktype, struct socka`
`227`	`227`	`for (n = 1; (sai = sai->ai_next) != NULL; n++)`
`228`	`228`	`;`
`229`	`229`
`230`		`- sal = safe_emalloc((n + 1), sizeof(sal), 0);`
	`230`	`+ sal = safe_emalloc((n + 1), sizeof(*sal), 0);`
`231`	`231`	`sai = res;`
`232`	`232`	`sap = *sal;`
`233`	`233`
`@@ -266,7 +266,7 @@ PHPAPI int php_network_getaddresses(const char *host, int socktype, struct socka`
`266`	`266`	`in = ((struct in_addr ) host_info->h_addr);`
`267`	`267`	`}`
`268`	`268`
`269`		`- sal = safe_emalloc(2, sizeof(sal), 0);`
	`269`	`+ sal = safe_emalloc(2, sizeof(*sal), 0);`
`270`	`270`	`sap = *sal;`
`271`	`271`	`*sap = emalloc(sizeof(struct sockaddr_in));`
`272`	`272`	`(*sap)->sa_family = AF_INET;`