Skip to content

Remove DOM_NO_ARGS() and DOM_NOT_IMPLEMENTED() #12147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Remove DOM_NO_ARGS() and DOM_NOT_IMPLEMENTED() #12147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UPGRADING.INTERNALS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ PHP 8.4 INTERNALS UPGRADE NOTES
a. ext/dom
- dom_read_t and dom_write_t now expect the function to return zend_result
instead of int.
- The macros DOM_NO_ARGS() and DOM_NOT_IMPLEMENTED() have been removed.

========================
4. OpCode changes
Expand Down
3 changes: 2 additions & 1 deletion ext/dom/domimplementation.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,8 @@ PHP_METHOD(DOMImplementation, getFeature)
RETURN_THROWS();
}

DOM_NOT_IMPLEMENTED();
zend_throw_error(NULL, "Not yet implemented");
RETURN_THROWS();
}
/* }}} end dom_domimplementation_get_feature */

Expand Down
9 changes: 0 additions & 9 deletions ext/dom/php_dom.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,15 +188,6 @@ int php_dom_get_nodelist_length(dom_object *obj);
__ptr = (__prtype)((php_libxml_node_ptr *)__intern->ptr)->node; \
}

#define DOM_NO_ARGS() \
if (zend_parse_parameters_none() == FAILURE) { \
RETURN_THROWS(); \
}

#define DOM_NOT_IMPLEMENTED() \
zend_throw_error(NULL, "Not yet implemented"); \
RETURN_THROWS();

#define DOM_NODELIST 0
#define DOM_NAMEDNODEMAP 1

Expand Down