Skip to content

Fix implicitly marking parameter as nullable deprecation warning #13714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Fix implicitly marking parameter as nullable deprecation warning #13714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions ext/phar/phar/pharcommand.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,15 +630,15 @@ class PharCommand extends CLICommand
* This function will take a directory and iterate through
* it and get the files to insert into the Phar archive.
*
* @param Phar $phar The phar object.
* @param string $input The input directory
* @param string $regex The regex used in RegexIterator.
* @param string $invregex The InvertedRegexIterator expression.
* @param SplFileInfo $stub Stub file object
* @param mixed $compress Compression algorithm or NULL
* @param boolean $noloader Whether to prevent adding the loader
*/
static function phar_add(Phar $phar, $level, $input, $regex, $invregex, SplFileInfo $stub = NULL, $compress = NULL, $noloader = false)
* @param Phar $phar The phar object.
* @param string $input The input directory
* @param string $regex The regex used in RegexIterator.
* @param string $invregex The InvertedRegexIterator expression.
* @param ?SplFileInfo $stub Stub file object
* @param mixed $compress Compression algorithm or NULL
* @param boolean $noloader Whether to prevent adding the loader
*/
static function phar_add(Phar $phar, $level, $input, $regex, $invregex, ?SplFileInfo $stub, $compress = NULL, $noloader = false)
{
if ($input && is_file($input) && !is_dir($input)) {
return self::phar_add_file($phar, $level, $input, $input, $compress);
Expand Down