Skip to content

Remove DOMImplementation::getFeature() #15233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ PHP NEWS
. Fixed bug GH-15192 (Segmentation fault in dom extension
(html5_serializer)). (nielsdos)
. Deprecated DOM_PHP_ERR constant. (nielsdos)
. Removed DOMImplementation::getFeature(). (nielsdos)

- PHPDBG:
. array out of bounds, stack overflow handled for segfault handler on windows.
Expand Down
4 changes: 4 additions & 0 deletions UPGRADING
Original file line number Diff line number Diff line change
Expand Up @@ -761,6 +761,10 @@ PHP 8.4 UPGRADE NOTES
- Date:
. The class constants are typed now.

- DOM:
. Removed DOMImplementation::getFeature().
RFC: https://wiki.php.net/rfc/deprecations_php_8_4#remove_domimplementationgetfeature_feature_version

- Intl:
. The class constants are typed now.
. The behaviour of Intl class has been normalized to always throw Error
Expand Down
17 changes: 0 additions & 17 deletions ext/dom/domimplementation.c
Original file line number Diff line number Diff line change
Expand Up @@ -415,21 +415,4 @@ PHP_METHOD(Dom_Implementation, createHTMLDocument)
}
/* }}} */

/* {{{ URL: http://www.w3.org/TR/2003/WD-DOM-Level-3-Core-20030226/DOM3-Core.html#DOMImplementation3-getFeature
Since: DOM Level 3
*/
PHP_METHOD(DOMImplementation, getFeature)
{
size_t feature_len, version_len;
char *feature, *version;

if (zend_parse_parameters(ZEND_NUM_ARGS(), "ss", &feature, &feature_len, &version, &version_len) == FAILURE) {
RETURN_THROWS();
}

zend_throw_error(NULL, "Not yet implemented");
RETURN_THROWS();
}
/* }}} end dom_domimplementation_get_feature */

#endif
3 changes: 0 additions & 3 deletions ext/dom/php_dom.stub.php
Original file line number Diff line number Diff line change
Expand Up @@ -454,9 +454,6 @@ public function __wakeup(): void {}

class DOMImplementation
{
/** @tentative-return-type */
public function getFeature(string $feature, string $version): never {}

/** @tentative-return-type */
public function hasFeature(string $feature, string $version): bool {}

Expand Down
9 changes: 1 addition & 8 deletions ext/dom/php_dom_arginfo.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading