Skip to content

relax test for zlib-ng #17617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

remicollet
Copy link
Member

Test failing with zlilb-ng 2.2

========DIFF========
--
       ["line"]=>
       int(%d)
     }
012- string(7) "Hello 6"
012+ string(6) "Hello "
========DONE========
FAIL GH-81475: Memory leak during stream filter failure [ext/standard/tests/filters/gh13264.phpt] 

@remicollet remicollet requested a review from bukka as a code owner January 29, 2025 08:47
@remicollet remicollet removed the request for review from bukka January 29, 2025 08:47
Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is fine. It's actually a bug that it returns a string which I plan to fix at some point (there are just few other items with higher priority but should be soon)

@remicollet
Copy link
Member Author

Merged as ed1d51f

@remicollet remicollet closed this Jan 29, 2025
@remicollet remicollet deleted the issue-zlib-ng branch January 29, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants