Skip to content

Expand FTP delete basic test with "unknown file" coverage #3814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

wardcapp
Copy link
Contributor

A port of the original phpcommunity/phptestfest-php-src#148 pull
request, created earlier during #PHPTestFest (User Group: PHP-WVL & PHPGent).

Expands the existing FTP delete command test with coverage for deletion of
non-existing files (which returns a 550 status code).

A port of the original phpcommunity/phptestfest-php-src#148 pull
request, created earlier during #PHPTestFest (User Group: PHP-WVL & PHPGent).
Expands the existing FTP delete command test with coverage for deletion of
non-existing files (which returns a 550 status code).
Copy link
Contributor

@carusogabriel carusogabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petk
Copy link
Member

petk commented Feb 10, 2019

Applied via f9d66ca to PHP-7.4 and master branches. Thank you @wardcapp for the pull request.

@petk petk closed this Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants