Removing 'bogus' memory exhaustions cheks in php_chunk_split() #4614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Aug 24, 2019
nikic
reviewed
Aug 24, 2019
Majkl578
reviewed
Aug 25, 2019
Girgias
force-pushed
the
bogus-check-php-chunk-split
branch
from
a429d4e to
ff8d2af
Compare
|
Looks like the 32-bit tests will need some adjustments. |
Girgias
force-pushed
the
bogus-check-php-chunk-split
branch
from
ff8d2af to
0c6ea7a
Compare
nikic
reviewed
Aug 25, 2019
Girgias
force-pushed
the
bogus-check-php-chunk-split
branch
from
0c6ea7a to
09d64dd
Compare
nikic
approved these changes
Aug 26, 2019
There was a problem hiding this comment.
Personally I would only add the ext/standard/tests/strings/chunk_split_variation1_32bit.phpt and ext/standard/tests/strings/chunk_split_variation2_32bit.phpt tests -- the other ones don't really show any "special" interesting behavior. On 64-bit those sizes are very far removed from overflow cases.
|
Merged in as 5b09e60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #4613
Not sure if the tests should use explicit line numbers.