Skip to content

Indent stubs inside global namespace blocks #7261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

kocsismate
Copy link
Member

Any objections?

Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kinda annoying, but I'm not going to block it. (It would not be indented with normal namespaces, and we only need the block form because we have some symbols in the global namespace.)

@kocsismate
Copy link
Member Author

This is kinda annoying, but I'm not going to block it. (It would not be indented with normal namespaces, and we only need the block form because we have some symbols in the global namespace.)

Yeah, I agree with the fact that it's a bit annoying. The reason why I'm suggesting this change is that I had a hard time to recognize which class is in which namespace when I had to work on some of these files, because the individual namespaces don't stand out if the indentation is missing.

@kocsismate kocsismate merged commit b382883 into php:master Jul 20, 2021
@kocsismate kocsismate deleted the stub-ns-indent branch July 20, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants