Skip to content

Declare DatePeriod properties #8534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2022
Merged

Conversation

kocsismate
Copy link
Member

No description provided.

@kocsismate kocsismate requested review from derickr, nikic, cmb69 and Girgias May 11, 2022 11:59
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense and looks good to me. But will let Derick review as he's the primary maintainer of ext/date.

@kocsismate kocsismate force-pushed the date-period-properties branch 3 times, most recently from 55625a3 to 2a9298b Compare May 12, 2022 06:12
@kocsismate kocsismate force-pushed the date-period-properties branch from 39c9454 to 211564e Compare May 13, 2022 09:23
@kocsismate kocsismate force-pushed the date-period-properties branch from 211564e to 3525f82 Compare May 16, 2022 11:05
@ramsey ramsey added this to the PHP 8.2 milestone May 21, 2022
@kocsismate
Copy link
Member Author

Can I ask for a second review round? :)

Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kocsismate kocsismate merged commit 21fe727 into php:master May 28, 2022
@kocsismate kocsismate deleted the date-period-properties branch May 28, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants