-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Declare DatePeriod properties #8534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense and looks good to me. But will let Derick review as he's the primary maintainer of ext/date.
55625a3
to
2a9298b
Compare
39c9454
to
211564e
Compare
211564e
to
3525f82
Compare
3525f82
to
cf55a18
Compare
Can I ask for a second review round? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.