Fix fake closure leaking when called from internal func #9884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced in 8e49d7f. ZEND_CALL_RELEASE_THIS was previously not handled for internal calls but just for user calls in the zend_leave_helper.
bwoebi
approved these changes
Nov 3, 2022
|
@bwoebi Thanks to Symfony 😄 https://github.com/php/php-src/actions/runs/3382367083/jobs/5617232070 |
|
Looks like a simple oversight, because DO_FCALL does it, for user and internal functions. Might well be that it's an existing bug causing issues in other cases too. |
|
@bwoebi You think this is worth back porting without a failing test? |
|
@iluuu1994 Actually, just checked the code, no it is not worth it: ZEND_INIT_DYNAMIC_CALL is the only source of ZEND_CALL_RELEASE_THIS. I.e. can only happen in VM - now it can happen in zend_call_function too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in 8e49d7f.
ZEND_CALL_RELEASE_THIS was previously not handled for internal calls but just for user calls in the zend_leave_helper.