Merge pull request #887 from phpDocumentor/cleanup-strval

jaapio · web-flow · commit d1abce032940 · 2024-03-01T22:34:52.000+01:00
Do not use strval function
diff --git a/packages/guides-theme-bootstrap/src/Bootstrap/Directives/TabDirective.php b/packages/guides-theme-bootstrap/src/Bootstrap/Directives/TabDirective.php
@@ -25,7 +25,6 @@
 use function preg_replace;
 use function str_replace;
 use function strtolower;
-use function strval;
 
 final class TabDirective extends SubDirective
 {
@@ -50,7 +49,7 @@ protected function processSub(
         }
 
         $key = str_replace(' ', '-', $key);
-        $key = strval(preg_replace('/[^a-zA-Z0-9\-_]/', '', $key));
+        $key = (string) (preg_replace('/[^a-zA-Z0-9\-_]/', '', $key));
         $active = $directive->hasOption('active');
 
         return new TabNode(

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@`
`25`	`25`	`use function preg_replace;`
`26`	`26`	`use function str_replace;`
`27`	`27`	`use function strtolower;`
`28`		`-use function strval;`
`29`	`28`
`30`	`29`	`final class TabDirective extends SubDirective`
`31`	`30`	`{`
`@@ -50,7 +49,7 @@ protected function processSub(`
`50`	`49`	`}`
`51`	`50`
`52`	`51`	`$key = str_replace(' ', '-', $key);`
`53`		`- $key = strval(preg_replace('/[^a-zA-Z0-9\-_]/', '', $key));`
	`52`	`+ $key = (string) (preg_replace('/[^a-zA-Z0-9\-_]/', '', $key));`
`54`	`53`	`$active = $directive->hasOption('active');`
`55`	`54`
`56`	`55`	`return new TabNode(`