Access precedence (#911)

* Failing test for expression list

* Fix access precedence

Author: dantleech

lib/Expression/NodeEvaluator/ArithmeticOperatorEvaluator.php

@@ -22,6 +22,7 @@ public function evaluate(Evaluator $evaluator, Node $node, array $params): ?Node
         }
 
         $leftValue = $evaluator->evaluateType($node->left(), NumberNode::class, $params);
+
         $rightValue = $evaluator->evaluateType($node->right(), NumberNode::class, $params);
 
         $value = $this->evaluateNode($node, $leftValue->value(), $rightValue->value());

lib/Expression/Parselet/ArrayAccessParselet.php

@@ -28,6 +28,6 @@ public function parse(Parser $parser, Node $left, Tokens $tokens): Node
 
     public function precedence(): int
     {
-        return Precedence::COMPARISON_EQUALITY;
+        return Precedence::ACCESS;
     }
 }

lib/Expression/Precedence.php

@@ -4,6 +4,7 @@
 
 final class Precedence
 {
+    public const ACCESS = 120;
     public const AS = 110;
     public const PRODUCT = 100;
     public const SUM = 90;

tests/Unit/Expression/Parselet/ArithmeticOperatorParseletTest.php

@@ -34,6 +34,14 @@ public function provideEvaluate(): Generator
         yield ['1 + 2', [], '3'];
 
         yield ['1 + 2 * 3 / 5 * 6 - 1', [], (string)(1 + 2 * 3 / 5 * 6 - 1)];
+
+        yield ['foo + foo', [
+            'foo' => 1,
+        ], '2'];
+
+        yield ['foo[0] + foo[0] * foo[0]', [
+            'foo' => [1],
+        ], '2'];
     }
 
     /**