Skip to content

Commit af099c2

Browse files
authored
Do not show ERROR log message if field not found (#1095)
* Do not show ERROR log message if field not found Not all executors provide the fields used by the default reports which can result in disturbing error messages being logged. This commit changes the log level to WARNING for evaluation errors and moves the "show messages" log level to WARNING. * Update CHANGELOG * Do not show stack trace
1 parent b78e7e9 commit af099c2

File tree

3 files changed

+14
-5
lines changed

3 files changed

+14
-5
lines changed

CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,17 @@
11
CHANGELOG
22
=========
33

4+
master
5+
------
6+
7+
- Hide noisy log messages for missing fields #1095 @dantleech
8+
- Defer character reader until command execution @jbboher #1092
9+
- Import Attribute symbol @gsteel #1075
10+
- Improved types etc @aivchen #1064 #1064 #1070 #1071 #1074 #1081...
11+
- Improved tests @aivchen
12+
- Improved code-style @aivchen #1057 #1076 #1070
13+
- Removed useless polyfills @aivchen
14+
415
1.2.15
516
------
617

lib/Logger/ConsoleLogger.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,11 @@ public function log($level, $message, array $context = []): void
2525
case LogLevel::DEBUG:
2626
case LogLevel::INFO:
2727
case LogLevel::NOTICE:
28+
case LogLevel::WARNING:
2829
if (!$this->enable) {
2930
return;
3031
}
3132

32-
break;
33-
case LogLevel::WARNING:
3433
$decoration = 'fg=yellow';
3534

3635
break;

lib/Report/Generator/ExpressionGenerator.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -197,11 +197,10 @@ private function evaluate(DataFrame $allFrame, DataFrames $frames, array $exprMa
197197
);
198198
} catch (EvaluationError $e) {
199199
$evaledRow[$name] = new StringNode('ERR');
200-
$this->logger->error(sprintf(
201-
'Expression error (column "%s"): %s %s',
200+
$this->logger->warning(sprintf(
201+
'Expression error (column "%s"): %s',
202202
$name,
203203
$e->getMessage(),
204-
$e->getTraceAsString()
205204
));
206205
}
207206
}

0 commit comments

Comments
 (0)