Skip to content

improve class.implements() #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brettmc opened this issue Mar 29, 2025 · 1 comment
Closed

improve class.implements() #188

brettmc opened this issue Mar 29, 2025 · 1 comment

Comments

@brettmc
Copy link
Contributor

brettmc commented Mar 29, 2025

Actually, you can find the interface through this method: https://docs.rs/phper/latest/phper/classes/struct.ClassEntry.html#method.from_globals

I think we can modify the prototype of implements, something like:

fn implements(&mut self, interface: Interface)

Then we can think about how to design it better later.

Originally posted by @jmjoy in #187 (comment)
@jmjoy
Copy link
Member

jmjoy commented Mar 31, 2025

Solved by #189

@jmjoy jmjoy closed this as completed Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettmc @jmjoy