Remove left overs of old array syntax

Signed-off-by: William Desportes <[email protected]>

Author: williamdes

README.md

@@ -56,7 +56,7 @@ cat example.sql | ./vendor/bin/lint-query
 ### Formatting SQL query
 
 ```php
-echo PhpMyAdmin\SqlParser\Utils\Formatter::format($query, array('type' => 'html'));
+echo PhpMyAdmin\SqlParser\Utils\Formatter::format($query, ['type' => 'html']);
 ```
 
 ### Discoverying query type

bin/highlight-query

@@ -2,12 +2,12 @@
 <?php
 declare(strict_types=1);
 
-$files = array(
+$files = [
     __DIR__ . "/../vendor/autoload.php",
     __DIR__ . "/../../vendor/autoload.php",
     __DIR__ . "/../../../autoload.php",
     "vendor/autoload.php"
-);
+];
 
 $found = false;
 foreach ($files as $file) {

bin/lint-query

@@ -2,12 +2,12 @@
 <?php
 declare(strict_types=1);
 
-$files = array(
+$files = [
     __DIR__ . "/../vendor/autoload.php",
     __DIR__ . "/../../vendor/autoload.php",
     __DIR__ . "/../../../autoload.php",
     "vendor/autoload.php"
-);
+];
 
 $found = false;
 foreach ($files as $file) {

bin/tokenize-query

@@ -2,12 +2,12 @@
 <?php
 declare(strict_types=1);
 
-$files = array(
+$files = [
     __DIR__ . "/../vendor/autoload.php",
     __DIR__ . "/../../vendor/autoload.php",
     __DIR__ . "/../../../autoload.php",
     "vendor/autoload.php"
-);
+];
 
 $found = false;
 foreach ($files as $file) {

src/Components/ArrayObj.php

@@ -147,11 +147,11 @@ public static function parse(Parser $parser, TokensList $list, array $options =
         //
         // This is treated differently to treat the following cases:
         //
-        //           => array()
-        //      (,)  => array('', '')
-        //      ()   => array()
-        //      (a,) => array('a', '')
-        //      (a)  => array('a')
+        //           => []
+        //      [,]  => ['', '']
+        //      []   => []
+        //      [a,] => ['a', '']
+        //      [a]  => ['a']
         $lastRaw = trim($lastRaw);
         if (empty($options['type'])
             && ((strlen($lastRaw) > 0) || ($isCommaLast))

src/Components/CreateDefinition.php

@@ -90,7 +90,7 @@ class CreateDefinition extends Component
         //
         // 'UNIQUE'                        => 4,
         // 'UNIQUE KEY'                    => 4,
-        // 'COMMENT'                       => array(5, 'var'),
+        // 'COMMENT'                       => [5, 'var'],
         // 'NOT NULL'                      => 1,
         // 'NULL'                          => 1,
         // 'PRIMARY'                       => 4,

src/Statements/SelectStatement.php

@@ -213,8 +213,8 @@ class SelectStatement extends Statement
             1,
         ],
         // These are available only when `UNION` is present.
-        // 'ORDER BY'                      => array('ORDER BY', 3),
-        // 'LIMIT'                         => array('LIMIT', 3),
+        // 'ORDER BY'                      => ['ORDER BY', 3],
+        // 'LIMIT'                         => ['LIMIT', 3],
     ];
 
     /**

src/Utils/Error.php

@@ -26,7 +26,7 @@ class Error
      *               `$err[1]` holds the error code.
      *               `$err[2]` holds the string that caused the issue.
      *               `$err[3]` holds the position of the string.
-     *               (i.e. `array($msg, $code, $str, $pos)`)
+     *               (i.e. `[$msg, $code, $str, $pos]`)
      */
     public static function get($objs)
     {

src/Utils/Formatter.php

@@ -170,7 +170,7 @@ protected function getDefaultOptions()
 
     /**
      * The styles used for HTML formatting.
-     * array($type, $flags, $span, $callback).
+     * [$type, $flags, $span, $callback].
      *
      * @return array
      */

src/Utils/Query.php

@@ -694,7 +694,7 @@ public static function replaceClause($statement, $list, $old, $new = null, $only
      * @param Statement  $statement the parsed query that has to be modified
      * @param TokensList $list      the list of tokens
      * @param array      $ops       Clauses to be replaced. Contains multiple
-     *                              arrays having two values: array($old, $new).
+     *                              arrays having two values: [$old, $new].
      *                              Clauses must be sorted.
      *
      * @return string

tests/Components/ExpressionTest.php

@@ -39,10 +39,10 @@ public function parseErrProvider()
     {
         return [
             /*
-            array(
+            [
                 '(1))',
                 'Unexpected closing bracket.',
-            ),
+            ],
             */
             [
                 'tbl..col',

tests/Utils/FormatterTest.php

@@ -59,7 +59,7 @@ public function testMergeFormats($default, $overriding, $expected)
 
     public function mergeFormats()
     {
-        // array($default[], $overriding[], $expected[])
+        // [default[], overriding[], expected[]]
         return [
             'empty formats' => [
                 'default' => [

tools/sami-config.php

@@ -14,9 +14,9 @@
     ->in("./src")
 ;
 
-return new Sami($iterator, array(
+return new Sami($iterator, [
     "title"                => "A validating SQL lexer and parser with a focus on MySQL dialect.",
     "build_dir"            => "./doc/",
     "cache_dir"            => "./tmp"
-));
+]);