Quote array / object keys when necessary

Fixes #251

Author: ruudk

src/Printer/Printer.php

@@ -186,6 +186,17 @@ public function printFormatPreserving(PhpDocNode $node, PhpDocNode $originalNode
 		return $this->print($node);
 	}
 
+	public function maybePrintQuoted(Node $node): string
+	{
+		$printed = $this->print($node);
+
+		if (!str_contains($printed, ' ')) {
+			return $printed;
+		}
+
+		return sprintf("'%s'", $printed);
+	}
+
 	public function print(Node $node): string
 	{
 		if ($node instanceof PhpDocNode) {
@@ -382,7 +393,7 @@ private function printType(TypeNode $node): string
 			if ($node->keyName !== null) {
 				return sprintf(
 					'%s%s: %s',
-					$this->print($node->keyName),
+					$this->maybePrintQuoted($node->keyName),
 					$node->optional ? '?' : '',
 					$this->printType($node->valueType)
 				);
@@ -489,7 +500,7 @@ private function printType(TypeNode $node): string
 			if ($node->keyName !== null) {
 				return sprintf(
 					'%s%s: %s',
-					$this->print($node->keyName),
+					$this->maybePrintQuoted($node->keyName),
 					$node->optional ? '?' : '',
 					$this->printType($node->valueType)
 				);

tests/PHPStan/Printer/PrinterTest.php

@@ -26,6 +26,7 @@
 use PHPStan\PhpDocParser\Ast\PhpDoc\ReturnTagValueNode;
 use PHPStan\PhpDocParser\Ast\PhpDoc\TemplateTagValueNode;
 use PHPStan\PhpDocParser\Ast\PhpDoc\TypeAliasImportTagValueNode;
+use PHPStan\PhpDocParser\Ast\PhpDoc\VarTagValueNode;
 use PHPStan\PhpDocParser\Ast\Type\ArrayShapeItemNode;
 use PHPStan\PhpDocParser\Ast\Type\ArrayShapeNode;
 use PHPStan\PhpDocParser\Ast\Type\ArrayShapeUnsealedTypeNode;
@@ -2064,4 +2065,24 @@ public function testPrintPhpDocNode(PhpDocNode $node, string $expectedResult): v
 		);
 	}
 
+	public function testMaybePrintQuoted(): void
+	{
+		$input = "array{states: array{'Hello World': int}, object{key: string, 'Other Key': int}}";
+		$expected = "array{states: array{'Hello World': int}, object{key: string, 'Other Key': int}}";
+		$lexer = new Lexer();
+		$constExprParser = new ConstExprParser(true, true);
+		$typeParser = new TypeParser($constExprParser);
+		$phpDocParser = new PhpDocParser($typeParser, $constExprParser);
+
+		$tokens = new TokenIterator($lexer->tokenize($input));
+		$phpDocNode = $phpDocParser->parseTagValue($tokens, '@var');
+
+		$this->assertInstanceOf(VarTagValueNode::class, $phpDocNode);
+		$this->assertInstanceOf(ArrayShapeNode::class, $phpDocNode->type);
+
+		$printer = new Printer();
+		$printed = $printer->print($phpDocNode);
+		$this->assertSame($expected, $printed);
+	}
+
 }