ClassMetadata is generic

Author: ondrejmirtes

extension.neon

@@ -9,8 +9,13 @@ parameters:
 		# setting this to false might lead to performance problems
 		# it changes the braching logic - with false, queryBuilders from all branches are analysed separately
 		queryBuilderFastAlgorithm: true
+	featureToggles:
+		skipCheckGenericClasses:
+			- Doctrine\ODM\MongoDB\Mapping\ClassMetadata
+			- Doctrine\ORM\Mapping\ClassMetadata
+			- Doctrine\ORM\Mapping\ClassMetadataInfo
+			- Doctrine\Persistence\Mapping\ClassMetadata
 	stubFiles:
-		- stubs/ClassMetadataInfo.stub
 		- stubs/Criteria.stub
 		- stubs/DocumentManager.stub
 		- stubs/DocumentRepository.stub
@@ -20,6 +25,7 @@ parameters:
 		- stubs/EntityRepository.stub
 		- stubs/ServiceEntityRepository.stub
 		- stubs/MongoClassMetadataInfo.stub
+
 		- stubs/Persistence/ManagerRegistry.stub
 		- stubs/Persistence/ObjectManager.stub
 		- stubs/Persistence/ObjectManagerDecorator.stub
@@ -30,6 +36,9 @@ parameters:
 		- stubs/Collections/Selectable.stub
 		- stubs/ORM/QueryBuilder.stub
 		- stubs/ORM/AbstractQuery.stub
+		- stubs/ORM/Mapping/ClassMetadata.stub
+		- stubs/ORM/Mapping/ClassMetadataInfo.stub
+		- stubs/Persistence/Mapping/ClassMetadata.stub
 		- stubs/ServiceDocumentRepository.stub
 
 parametersSchema:

phpstan-baseline.neon

@@ -1,7 +1,6 @@
 includes:
 	- extension.neon
 	- rules.neon
-	- phpstan-baseline.neon
 	- vendor/phpstan/phpstan-strict-rules/rules.neon
 	- vendor/phpstan/phpstan-phpunit/extension.neon
 	- vendor/phpstan/phpstan-phpunit/rules.neon

phpstan.neon

@@ -30,6 +30,7 @@ public function isAlwaysRead(PropertyReflection $property, string $propertyName)
 
 	/**
 	 * @param class-string $className
+	 * @return \Doctrine\ORM\Mapping\ClassMetadataInfo<object>
 	 */
 	private function findMetadata(string $className): ?\Doctrine\ORM\Mapping\ClassMetadataInfo
 	{

src/Rules/Doctrine/ORM/PropertiesExtension.php

@@ -115,14 +115,14 @@ public function getRepositoryClass(string $className): string
 
 		$ormMetadataClass = 'Doctrine\ORM\Mapping\ClassMetadata';
 		if ($metadata instanceof $ormMetadataClass) {
-			/** @var \Doctrine\ORM\Mapping\ClassMetadata $ormMetadata */
+			/** @var \Doctrine\ORM\Mapping\ClassMetadata<object> $ormMetadata */
 			$ormMetadata = $metadata;
 			return $ormMetadata->customRepositoryClassName ?? $this->getResolvedRepositoryClass();
 		}
 
 		$odmMetadataClass = 'Doctrine\ODM\MongoDB\Mapping\ClassMetadata';
 		if ($metadata instanceof $odmMetadataClass) {
-			/** @var \Doctrine\ODM\MongoDB\Mapping\ClassMetadata $odmMetadata */
+			/** @var \Doctrine\ODM\MongoDB\Mapping\ClassMetadata<object> $odmMetadata */
 			$odmMetadata = $metadata;
 			return $odmMetadata->customRepositoryClassName ?? $this->getResolvedRepositoryClass();
 		}

src/Type/Doctrine/ObjectMetadataResolver.php

@@ -2,10 +2,40 @@
 
 namespace Doctrine\ODM\MongoDB\Mapping;
 
-class ClassMetadata
+use Doctrine\Persistence\Mapping\ClassMetadata as BaseClassMetadata;
+use ReflectionClass;
+
+/**
+ * @template-covariant T of object
+ * @template-implements BaseClassMetadata<T>
+ */
+class ClassMetadata implements BaseClassMetadata
 {
 
 	/** @var string|null */
 	public $customRepositoryClassName;
 
+	/**
+	 * @var class-string<T>
+	 */
+	public $name;
+
+	/**
+	 * @param class-string<T> $documentName
+	 */
+	public function __construct(string $documentName)
+	{
+
+	}
+
+	/**
+	 * @return class-string<T>
+	 */
+	public function getName();
+
+	/**
+	 * @return ReflectionClass<T>
+	 */
+	public function getReflectionClass();
+
 }

stubs/ClassMetadataInfo.stub

@@ -0,0 +1,18 @@
+<?php
+
+namespace Doctrine\ORM\Mapping;
+
+/**
+ * @template-covariant T of object
+ * @extends ClassMetadataInfo<T>
+ */
+class ClassMetadata extends ClassMetadataInfo
+{
+    /**
+     * @param class-string<T> $entityName
+     */
+    public function __construct($entityName)
+    {
+
+    }
+}

stubs/MongoClassMetadataInfo.stub

@@ -0,0 +1,50 @@
+<?php
+
+namespace Doctrine\ORM\Mapping;
+
+use Doctrine\Persistence\Mapping\ClassMetadata;
+use ReflectionClass;
+
+/**
+ * @template-covariant T of object
+ * @implements ClassMetadata<T>
+ */
+class ClassMetadataInfo implements ClassMetadata
+{
+
+	/** @var string|null */
+	public $customRepositoryClassName;
+
+	/**
+     * @param class-string<T> $entityName
+     */
+    public function __construct($entityName)
+    {
+
+    }
+
+    /**
+	 * @param string $assocName
+	 * @return class-string
+	 */
+	public function getAssociationTargetClass($assocName);
+
+    /**
+	 * @return T
+	 */
+	public function newInstance()
+	{
+
+	}
+
+	/**
+	 * @return class-string<T>
+	 */
+	public function getName();
+
+	/**
+	 * @return ReflectionClass<T>
+	 */
+	public function getReflectionClass();
+
+}

stubs/ORM/Mapping/ClassMetadata.stub

@@ -0,0 +1,21 @@
+<?php
+
+namespace Doctrine\Persistence\Mapping;
+
+use ReflectionClass;
+
+/**
+ * @template-covariant T of object
+ */
+interface ClassMetadata
+{
+    /**
+     * @return class-string<T>
+     */
+    public function getName();
+
+    /**
+     * @return ReflectionClass<T>
+     */
+    public function getReflectionClass();
+}