Fix missing field mappings in Doctrine

curry684 · ondrejmirtes · commit f159eb929b17 · 2022-10-17T16:01:15.000+02:00
diff --git a/src/Rules/Doctrine/ORM/PropertiesExtension.php b/src/Rules/Doctrine/ORM/PropertiesExtension.php
@@ -45,9 +45,11 @@ public function isAlwaysWritten(PropertyReflection $property, string $propertyNa
 			return false;
 		}
 
-		$mapping = $metadata->getFieldMapping($propertyName);
-		if (array_key_exists('generated', $mapping) && $mapping['generated'] !== ClassMetadataInfo::GENERATED_NEVER) {
-			return true;
+		if (isset($metadata->fieldMappings[$propertyName])) {
+			$mapping = $metadata->fieldMappings[$propertyName];
+			if (array_key_exists('generated', $mapping) && $mapping['generated'] !== ClassMetadataInfo::GENERATED_NEVER) {
+				return true;
+			}
 		}
 
 		if ($metadata->isReadOnly && !$declaringClass->hasConstructor()) {

Original file line number	Diff line number	Diff line change
`@@ -45,9 +45,11 @@ public function isAlwaysWritten(PropertyReflection $property, string $propertyNa`
`45`	`45`	`return false;`
`46`	`46`	`}`
`47`	`47`
`48`		`- $mapping = $metadata->getFieldMapping($propertyName);`
`49`		`- if (array_key_exists('generated', $mapping) && $mapping['generated'] !== ClassMetadataInfo::GENERATED_NEVER) {`
`50`		`- return true;`
	`48`	`+ if (isset($metadata->fieldMappings[$propertyName])) {`
	`49`	`+ $mapping = $metadata->fieldMappings[$propertyName];`
	`50`	`+ if (array_key_exists('generated', $mapping) && $mapping['generated'] !== ClassMetadataInfo::GENERATED_NEVER) {`
	`51`	`+ return true;`
	`52`	`+ }`
`51`	`53`	`}`
`52`	`54`
`53`	`55`	`if ($metadata->isReadOnly && !$declaringClass->hasConstructor()) {`