assertStringStartsWith after assertNotEmpty fails

[gisostallenberg]

assertStringStartsWith after assertNotEmpty fails with error "Parameter #1 $prefix of method PHPUnit\Framework\Assert::assertStringStartsWith() expects non-empty-string', while the string cannot be empty due to the assertNotEmpty call.

<?php

use PHPUnit\Framework\TestCase;

class FooTest extends TestCase {
    public function testFoo(): void
    {
        $string = ([
            '',
            'bar',
        ])[rand(0, 1)];
        $this->assertNotEmpty($string);
        $this->assertStringStartsWith($string, 'baz');
    }
}

[ondrejmirtes]

Can't reproduce the problem: https://phpstan.org/r/91888ed1-d67f-4749-9d9c-a617da10722b

Please show the output of vendor/bin/phpstan diagnose.

[ondrejmirtes]

I get the problem now, phpstan-phpunit has a special type-specifying extension that doesn't work for strings:

phpstan-phpunit/src/Type/PHPUnit/Assert/AssertTypeSpecifyingExtensionHelper.php

Lines 168 to 177 in d35895e

	'Empty' => static fn (Scope $scope, Arg $actual): Expr\BinaryOp\BooleanOr => new Expr\BinaryOp\BooleanOr(
	new Instanceof_($actual->value, new Name(EmptyIterator::class)),
	new Expr\BinaryOp\BooleanOr(
	new Expr\BinaryOp\BooleanAnd(
	new Instanceof_($actual->value, new Name(Countable::class)),
	new Identical(new FuncCall(new Name('count'), [new Arg($actual->value)]), new LNumber(0)),
	),
	new Expr\Empty_($actual->value),
	),
	),