Add support for multiple wildcards in const type annotations, fixes phpstan/phpstan#5534

Author: Seldaek

composer.json

@@ -25,7 +25,7 @@
 		"ondram/ci-detector": "^3.4.0",
 		"ondrejmirtes/better-reflection": "4.3.67",
 		"phpstan/php-8-stubs": "^0.1.23",
-		"phpstan/phpdoc-parser": "^0.5.6",
+		"phpstan/phpdoc-parser": "^0.5.7",
 		"react/child-process": "^0.6.1",
 		"react/event-loop": "^1.1",
 		"react/http": "^1.1",

composer.lock

@@ -702,11 +702,12 @@ private function resolveConstTypeNode(ConstTypeNode $typeNode, NameScope $nameSc
 			$classReflection = $this->getReflectionProvider()->getClass($className);
 
 			$constantName = $constExpr->name;
-			if (Strings::endsWith($constantName, '*')) {
-				$constantNameStartsWith = Strings::substring($constantName, 0, Strings::length($constantName) - 1);
+			if (Strings::contains($constantName, '*')) {
+				// convert * into .*? and escape everything else so the constants can be matched against the pattern
+				$pattern = '{^' . str_replace('\\*', '.*?', preg_quote($constantName)) . '$}D';
 				$constantTypes = [];
 				foreach ($classReflection->getNativeReflection()->getConstants() as $classConstantName => $constantValue) {
-					if (!Strings::startsWith($classConstantName, $constantNameStartsWith)) {
+					if (Strings::match($classConstantName, $pattern) === null) {
 						continue;
 					}
 

src/PhpDoc/TypeNodeResolver.php

@@ -10,6 +10,9 @@ class Foo
 
 	public const SOME_CONSTANT = 1;
 	public const SOME_OTHER_CONSTANT = 2;
+	public const YET_ONE_CONST = 3;
+	public const YET_ANOTHER_CONST = 4;
+	public const DUMMY_SOME_CONSTANT = 99; // should only match the *
 
 	/**
 	 * @param 'foo'|'bar' $one
@@ -21,6 +24,9 @@ class Foo
 	 * @param 234 $seven
 	 * @param self::SOME_OTHER_* $eight
 	 * @param self::* $nine
+	 * @param self::*_CONST $ten
+	 * @param self::YET_*_CONST $eleven
+	 * @param self::*OTHER* $twelve
 	 */
 	public function doFoo(
 		$one,
@@ -31,7 +37,10 @@ public function doFoo(
 		$six,
 		$seven,
 		$eight,
-		$nine
+		$nine,
+		$ten,
+		$eleven,
+		$twelve
 	)
 	{
 		assertType("'bar'|'foo'", $one);
@@ -42,7 +51,10 @@ public function doFoo(
 		assertType('1.0', $six);
 		assertType('234', $seven);
 		assertType('2', $eight);
-		assertType('1|2', $nine);
+		assertType('1|2|3|4|99', $nine);
+		assertType('3|4', $ten);
+		assertType('3|4', $eleven);
+		assertType('2|4', $twelve);
 	}
 
 }