Add hint as to what might be wrong when invalid identifiers are used

Seldaek · ondrejmirtes · commit 2505e94581aa · 2024-07-12T11:20:46.000+02:00
diff --git a/src/Rules/RuleErrorBuilder.php b/src/Rules/RuleErrorBuilder.php
@@ -221,7 +221,7 @@ public function treatPhpDocTypesAsCertainTip(): self
 	public function identifier(string $identifier): self
 	{
 		if (!Error::validateIdentifier($identifier)) {
-			throw new ShouldNotHappenException(sprintf('Invalid identifier: %s', $identifier));
+			throw new ShouldNotHappenException(sprintf('Invalid identifier: %s, error identifiers must match /%s/', $identifier, Error::PATTERN_IDENTIFIER));
 		}
 
 		$this->properties['identifier'] = $identifier;

Original file line number	Diff line number	Diff line change
`@@ -221,7 +221,7 @@ public function treatPhpDocTypesAsCertainTip(): self`
`221`	`221`	`public function identifier(string $identifier): self`
`222`	`222`	`{`
`223`	`223`	`if (!Error::validateIdentifier($identifier)) {`
`224`		`- throw new ShouldNotHappenException(sprintf('Invalid identifier: %s', $identifier));`
	`224`	`+ throw new ShouldNotHappenException(sprintf('Invalid identifier: %s, error identifiers must match /%s/', $identifier, Error::PATTERN_IDENTIFIER));`
`225`	`225`	`}`
`226`	`226`
`227`	`227`	`$this->properties['identifier'] = $identifier;`