Assure GitLab error formatter have integer line properties

Author: simonhammes

src/Command/ErrorFormatter/GitlabErrorFormatter.php

@@ -41,7 +41,7 @@ public function formatErrors(AnalysisResult $analysisResult, Output $output): in
 				'location' => [
 					'path' => $this->relativePathHelper->getRelativePath($fileSpecificError->getFile()),
 					'lines' => [
-						'begin' => $fileSpecificError->getLine(),
+						'begin' => $fileSpecificError->getLine() ?? 0,
 					],
 				],
 			];

src/Testing/ErrorFormatterTestCase.php

@@ -60,7 +60,7 @@ protected function getOutputContent(): string
 
 	protected function getAnalysisResult(int $numFileErrors, int $numGenericErrors): AnalysisResult
 	{
-		if ($numFileErrors > 4 || $numFileErrors < 0 || $numGenericErrors > 2 || $numGenericErrors < 0) {
+		if ($numFileErrors > 5 || $numFileErrors < 0 || $numGenericErrors > 2 || $numGenericErrors < 0) {
 			throw new \PHPStan\ShouldNotHappenException();
 		}
 
@@ -69,6 +69,7 @@ protected function getAnalysisResult(int $numFileErrors, int $numGenericErrors):
 			new Error('Foo', self::DIRECTORY_PATH . '/foo.php', 1),
 			new Error("Bar\nBar2", self::DIRECTORY_PATH . '/foo.php', 5),
 			new Error("Bar\nBar2", self::DIRECTORY_PATH . '/folder with unicode 😃/file name with "spaces" and unicode 😃.php', 2),
+			new Error("Bar\nBar2", self::DIRECTORY_PATH . '/foo.php', null),
 		], 0, $numFileErrors);
 
 		$genericErrors = array_slice([

tests/PHPStan/Command/ErrorFormatter/GitlabFormatterTest.php

@@ -111,6 +111,70 @@ public function dataFormatterOutputProvider(): iterable
 ]',
 		];
 
+		yield [
+			'Multiple file errors, including error with line=null',
+			1,
+			5,
+			0,
+			'[
+    {
+        "description": "Bar\nBar2",
+        "fingerprint": "034b4afbfb347494c14e396ed8327692f58be4cd27e8aff5f19f4194934db7c9",
+        "severity": "major",
+        "location": {
+            "path": "with space/and unicode 😃/project/folder with unicode 😃/file name with \"spaces\" and unicode 😃.php",
+            "lines": {
+                "begin": 2
+            }
+        }
+    },
+    {
+        "description": "Foo",
+        "fingerprint": "e82b7e1f1d4255352b19ecefa9116a12f129c7edb4351cf2319285eccdb1565e",
+        "severity": "major",
+        "location": {
+            "path": "with space/and unicode 😃/project/folder with unicode 😃/file name with \"spaces\" and unicode 😃.php",
+            "lines": {
+                "begin": 4
+            }
+        }
+    },
+    {
+        "description": "Bar\nBar2",
+        "fingerprint": "52d22d9e64bd6c6257b7a0d170ed8c99482043aeedd68c52bac081a80da9800a",
+        "severity": "major",
+        "location": {
+            "path": "with space/and unicode \ud83d\ude03/project/foo.php",
+            "lines": {
+                "begin": 0
+            }
+        }
+    },
+    {
+        "description": "Foo",
+        "fingerprint": "93c79740ed8c6fbaac2087e54d6f6f67fc0918e3ff77840530f32e19857ef63c",
+        "severity": "major",
+        "location": {
+            "path": "with space/and unicode \ud83d\ude03/project/foo.php",
+            "lines": {
+                "begin": 1
+            }
+        }
+    },
+    {
+        "description": "Bar\nBar2",
+        "fingerprint": "829f6c782152fdac840b39208c5b519d18e51bff2c601b6197812fffb8bcd9ed",
+        "severity": "major",
+        "location": {
+            "path": "with space/and unicode \ud83d\ude03/project/foo.php",
+            "lines": {
+                "begin": 5
+            }
+        }
+    }
+]',
+		];
+
 		yield [
 			'Multiple generic errors',
 			1,