Use RuleErrorBuilder and add method for checking case-insensitive constants support

Author: mglaman

src/Php/PhpVersion.php

@@ -147,4 +147,9 @@ public function supportsEnums(): bool
 		return $this->versionId >= 80100;
 	}
 
+	public function supportsCaseInsensitiveConstantNames(): bool
+	{
+		return $this->versionId < 80000;
+	}
+
 }

src/Rules/Functions/DefineParametersRule.php

@@ -6,6 +6,7 @@
 use PhpParser\Node\Expr\FuncCall;
 use PHPStan\Analyser\Scope;
 use PHPStan\Php\PhpVersion;
+use PHPStan\Rules\RuleErrorBuilder;
 
 /**
  * @implements \PHPStan\Rules\Rule<\PhpParser\Node\Expr\FuncCall>
@@ -30,7 +31,7 @@ public function processNode(Node $node, Scope $scope): array
 		if (!($node->name instanceof \PhpParser\Node\Name)) {
 			return [];
 		}
-		if ($this->phpVersion->getVersionId() < 80000) {
+		if ($this->phpVersion->supportsCaseInsensitiveConstantNames()) {
 			return [];
 		}
 		$name = strtolower((string) $node->name);
@@ -39,12 +40,14 @@ public function processNode(Node $node, Scope $scope): array
 		}
 		$args = $node->getArgs();
 		$argsCount = count($args);
-		// Expects 2, 1 arg is caught by CallToFunctionParametersRule
+		// Expects 2 or 3, 1 arg is caught by CallToFunctionParametersRule
 		if ($argsCount < 3) {
 			return [];
 		}
 		return [
-			'Argument #3 ($case_insensitive) is ignored since declaration of case-insensitive constants is no longer supported.',
+			RuleErrorBuilder::message(
+				'Argument #3 ($case_insensitive) is ignored since declaration of case-insensitive constants is no longer supported.'
+			)->line($node->getLine())->build(),
 		];
 	}
 

tests/PHPStan/Rules/Functions/DefineParametersRuleTest.php

@@ -18,14 +18,15 @@ protected function getRule(): \PHPStan\Rules\Rule
 	public function testFile(): void
 	{
 		if (PHP_VERSION_ID < 80000) {
-			$this->markTestSkipped('Test requires PHP 8.0.');
+			$this->analyse([__DIR__ . '/data/call-to-define.php'], []);
+		} else {
+			$this->analyse([__DIR__ . '/data/call-to-define.php'], [
+				[
+					'Argument #3 ($case_insensitive) is ignored since declaration of case-insensitive constants is no longer supported.',
+					3,
+				],
+			]);
 		}
-		$this->analyse([__DIR__ . '/data/call-to-define.php'], [
-			[
-				'Argument #3 ($case_insensitive) is ignored since declaration of case-insensitive constants is no longer supported.',
-				3,
-			],
-		]);
 	}
 
 }

tests/PHPStan/Rules/Functions/data/call-to-define.php

@@ -1,3 +1,6 @@
 <?php
 
 define('CaSeInSeNsItIvE', 0, true);
+define('CaSeInSeNsItIvE_IsOK', 0);
+define('all_lowercase', 1);
+define('ALL_UPPERCASE', 1);