Fix

Author: ondrejmirtes

composer.json

@@ -23,7 +23,7 @@
 		"nette/utils": "^3.1.3",
 		"nikic/php-parser": "4.12.0",
 		"ondram/ci-detector": "^3.4.0",
-		"ondrejmirtes/better-reflection": "4.3.63",
+		"ondrejmirtes/better-reflection": "4.3.64",
 		"phpstan/php-8-stubs": "^0.1.22",
 		"phpstan/phpdoc-parser": "^0.5.5",
 		"react/child-process": "^0.6.1",

composer.lock

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Reflection;
 
+use PHPStan\Php\PhpVersion;
 use PHPStan\TrinaryLogic;
 use PHPStan\Type\ConstantTypeHelper;
 use PHPStan\Type\Type;
@@ -15,6 +16,8 @@ class ClassConstantReflection implements ConstantReflection
 
 	private ?Type $phpDocType;
 
+	private PhpVersion $phpVersion;
+
 	private ?string $deprecatedDescription;
 
 	private bool $isDeprecated;
@@ -27,6 +30,7 @@ public function __construct(
 		ClassReflection $declaringClass,
 		\ReflectionClassConstant $reflection,
 		?Type $phpDocType,
+		PhpVersion $phpVersion,
 		?string $deprecatedDescription,
 		bool $isDeprecated,
 		bool $isInternal
@@ -35,6 +39,7 @@ public function __construct(
 		$this->declaringClass = $declaringClass;
 		$this->reflection = $reflection;
 		$this->phpDocType = $phpDocType;
+		$this->phpVersion = $phpVersion;
 		$this->deprecatedDescription = $deprecatedDescription;
 		$this->isDeprecated = $isDeprecated;
 		$this->isInternal = $isInternal;
@@ -107,7 +112,11 @@ public function isFinal(): bool
 			return $this->reflection->isFinal();
 		}
 
-		return false;
+		if (!$this->phpVersion->isInterfaceConstantImplicitlyFinal()) {
+			return false;
+		}
+
+		return $this->declaringClass->isInterface();
 	}
 
 	public function isDeprecated(): TrinaryLogic

src/Reflection/ClassConstantReflection.php

@@ -821,6 +821,7 @@ public function getConstant(string $name): ConstantReflection
 				$declaringClass,
 				$reflectionConstant,
 				$phpDocType,
+				$this->phpVersion,
 				$deprecatedDescription,
 				$isDeprecated,
 				$isInternal

src/Reflection/ClassReflection.php

@@ -4,7 +4,6 @@
 
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
-use PHPStan\Php\PhpVersion;
 use PHPStan\Reflection\ClassConstantReflection;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\ConstantReflection;
@@ -19,16 +18,12 @@
 class OverridingConstantRule implements Rule
 {
 
-	private PhpVersion $phpVersion;
-
 	private bool $checkPhpDocMethodSignatures;
 
 	public function __construct(
-		PhpVersion $phpVersion,
 		bool $checkPhpDocMethodSignatures
 	)
 	{
-		$this->phpVersion = $phpVersion;
 		$this->checkPhpDocMethodSignatures = $checkPhpDocMethodSignatures;
 	}
 
@@ -69,13 +64,7 @@ private function processSingleConstant(ClassReflection $classReflection, string
 		}
 
 		$errors = [];
-		if (
-			$prototype->isFinal()
-			|| (
-				$this->phpVersion->isInterfaceConstantImplicitlyFinal()
-				&& $prototype->getDeclaringClass()->isInterface()
-			)
-		) {
+		if ($prototype->isFinal()) {
 			$errors[] = RuleErrorBuilder::message(sprintf(
 				'Constant %s::%s overrides final constant %s::%s.',
 				$classReflection->getDisplayName(),

src/Rules/Constants/OverridingConstantRule.php

@@ -2,7 +2,6 @@
 
 namespace PHPStan\Rules\Constants;
 
-use PHPStan\Php\PhpVersion;
 use PHPStan\Testing\RuleTestCase;
 
 /** @extends RuleTestCase<OverridingConstantRule> */
@@ -11,7 +10,7 @@ class OverridingConstantRuleTest extends RuleTestCase
 
 	protected function getRule(): \PHPStan\Rules\Rule
 	{
-		return new OverridingConstantRule(new PhpVersion(PHP_VERSION_ID), true);
+		return new OverridingConstantRule(true);
 	}
 
 	public function testRule(): void