Skip to content

Commit 83ccb7f

Browse files
author
Michael Voříšek
authored
Remove line from "nikic/php-parser" error message
1 parent 542cb0a commit 83ccb7f

File tree

4 files changed

+18
-2
lines changed

4 files changed

+18
-2
lines changed

src/Analyser/FileAnalyser.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ public function analyseFile(
207207
}
208208
}
209209
} catch (\PhpParser\Error $e) {
210-
$fileErrors[] = new Error($e->getMessage(), $file, $e->getStartLine() !== -1 ? $e->getStartLine() : null, $e);
210+
$fileErrors[] = new Error($e->getRawMessage(), $file, $e->getStartLine() !== -1 ? $e->getStartLine() : null, $e);
211211
} catch (ParserErrorsException $e) {
212212
foreach ($e->getErrors() as $error) {
213213
$fileErrors[] = new Error($error->getMessage(), $e->getParsedFile() ?? $file, $error->getStartLine() !== -1 ? $error->getStartLine() : null, $e);

src/Parser/ParserErrorsException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public function __construct(
2222
private ?string $parsedFile,
2323
)
2424
{
25-
parent::__construct(implode(', ', array_map(static fn (Error $error): string => $error->getMessage(), $errors)));
25+
parent::__construct(implode(', ', array_map(static fn (Error $error): string => $error->getRawMessage(), $errors)));
2626
if (count($errors) > 0) {
2727
$this->attributes = $errors[0]->getAttributes();
2828
} else {

tests/PHPStan/Analyser/AnalyserIntegrationTest.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1285,6 +1285,14 @@ public function testBug10302(): void
12851285
$this->assertNoErrors($errors);
12861286
}
12871287

1288+
public function testBug10358(): void
1289+
{
1290+
$errors = $this->runAnalyse(__DIR__ . '/data/bug-10358.php');
1291+
$this->assertCount(1, $errors);
1292+
$this->assertSame('Cannot use Ns\Foo2 as Foo because the name is already in use', $errors[0]->getMessage());
1293+
$this->assertSame(6, $errors[0]->getLine());
1294+
}
1295+
12881296
public function testBug10509(): void
12891297
{
12901298
$errors = $this->runAnalyse(__DIR__ . '/data/bug-10509.php');
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<?php
2+
3+
namespace Bug10358;
4+
5+
use Ns\Foo;
6+
use Ns\Foo2 as Foo;
7+
8+
class Foo {}

0 commit comments

Comments
 (0)