Add missing getAttributes for all supported reflectors

Author: vhenzl

conf/config.neon

@@ -1494,10 +1494,41 @@ services:
 			- phpstan.broker.dynamicStaticMethodReturnTypeExtension
 
 	-
-		class: PHPStan\Type\Php\ReflectionClassGetAttributesMethodReturnTypeExtension
+		class: PHPStan\Type\Php\ReflectionGetAttributesMethodReturnTypeExtension
+		arguments:
+			className: ReflectionClass
+		tags:
+			- phpstan.broker.dynamicMethodReturnTypeExtension
+
+	-
+		class: PHPStan\Type\Php\ReflectionGetAttributesMethodReturnTypeExtension
+		arguments:
+			className: ReflectionClassConstant
+		tags:
+			- phpstan.broker.dynamicMethodReturnTypeExtension
+
+	-
+		class: PHPStan\Type\Php\ReflectionGetAttributesMethodReturnTypeExtension
+		arguments:
+			className: ReflectionFunctionAbstract
 		tags:
 			- phpstan.broker.dynamicMethodReturnTypeExtension
 
+	-
+		class: PHPStan\Type\Php\ReflectionGetAttributesMethodReturnTypeExtension
+		arguments:
+			className: ReflectionParameter
+		tags:
+			- phpstan.broker.dynamicMethodReturnTypeExtension
+
+	-
+		class: PHPStan\Type\Php\ReflectionGetAttributesMethodReturnTypeExtension
+		arguments:
+			className: ReflectionProperty
+		tags:
+			- phpstan.broker.dynamicMethodReturnTypeExtension
+
+
 	exceptionTypeResolver:
 		class: PHPStan\Rules\Exceptions\ExceptionTypeResolver
 		factory: @PHPStan\Rules\Exceptions\DefaultExceptionTypeResolver

conf/config.stubFiles.neon

@@ -2,12 +2,15 @@ parameters:
 	stubFiles:
 		- ../stubs/ReflectionAttribute.stub
 		- ../stubs/ReflectionClass.stub
+		- ../stubs/ReflectionClassConstant.stub
+		- ../stubs/ReflectionFunctionAbstract.stub
+		- ../stubs/ReflectionParameter.stub
+		- ../stubs/ReflectionProperty.stub
 		- ../stubs/iterable.stub
 		- ../stubs/ArrayObject.stub
 		- ../stubs/WeakReference.stub
 		- ../stubs/ext-ds.stub
 		- ../stubs/PDOStatement.stub
-		- ../stubs/ReflectionFunctionAbstract.stub
 		- ../stubs/date.stub
 		- ../stubs/zip.stub
 		- ../stubs/dom.stub

src/Type/Php/ReflectionClassGetAttributesMethodReturnTypeExtension.php renamed to src/Type/Php/ReflectionGetAttributesMethodReturnTypeExtension.php

@@ -15,12 +15,23 @@
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 
-class ReflectionClassGetAttributesMethodReturnTypeExtension implements DynamicMethodReturnTypeExtension
+class ReflectionGetAttributesMethodReturnTypeExtension implements DynamicMethodReturnTypeExtension
 {
 
+	/** @var class-string */
+	private string $className;
+
+	/**
+	 * @param class-string $className One of reflection classes: https://www.php.net/manual/en/book.reflection.php
+	 */
+	public function __construct(string $className)
+	{
+		$this->className = $className;
+	}
+
 	public function getClass(): string
 	{
-		return \ReflectionClass::class;
+		return $this->className;
 	}
 
 	public function isMethodSupported(MethodReflection $methodReflection): bool

stubs/ReflectionClassConstant.stub

@@ -0,0 +1,11 @@
+<?php
+
+class ReflectionClassConstant
+{
+    /**
+     * @return array<ReflectionAttribute<object>>
+     */
+    public function getAttributes(?string $name = null, int $flags = 0)
+    {
+    }
+}

stubs/ReflectionFunctionAbstract.stub

@@ -8,4 +8,10 @@ abstract class ReflectionFunctionAbstract
 	 */
 	public function getFileName () {}
 
+    /**
+     * @return array<ReflectionAttribute<object>>
+     */
+    public function getAttributes(?string $name = null, int $flags = 0)
+    {
+    }
 }

stubs/ReflectionParameter.stub

@@ -0,0 +1,11 @@
+<?php
+
+class ReflectionParameter
+{
+    /**
+     * @return array<ReflectionAttribute<object>>
+     */
+    public function getAttributes(?string $name = null, int $flags = 0)
+    {
+    }
+}

stubs/ReflectionProperty.stub

@@ -0,0 +1,11 @@
+<?php
+
+class ReflectionProperty
+{
+    /**
+     * @return array<ReflectionAttribute<object>>
+     */
+    public function getAttributes(?string $name = null, int $flags = 0)
+    {
+    }
+}

tests/PHPStan/Analyser/data/reflectionclass-issue-5511-php8.php

@@ -9,35 +9,63 @@ class Abc
 {
 }
 
-#[Abc]
-class X
-{
-}
-
 /**
  * @param string $str
  * @param class-string $className
  * @param class-string<Abc> $genericClassName
  */
-function testGetAttributes(string $str, string $className, string $genericClassName): void
+function testGetAttributes(
+	\ReflectionClass $reflectionClass,
+	\ReflectionMethod $reflectionMethod,
+	\ReflectionParameter $reflectionParameter,
+	\ReflectionProperty $reflectionProperty,
+	\ReflectionClassConstant $reflectionClassConstant,
+	\ReflectionFunction $reflectionFunction,
+	string $str,
+	string $className,
+	string $genericClassName
+): void
 {
-	$class = new \ReflectionClass(X::class);
-
-	$attrsAll = $class->getAttributes();
-	$attrsAbc1 = $class->getAttributes(Abc::class);
-	$attrsAbc2 = $class->getAttributes(Abc::class, \ReflectionAttribute::IS_INSTANCEOF);
-	$attrsGCN = $class->getAttributes($genericClassName);
-	$attrsCN = $class->getAttributes($className);
-	$attrsStr = $class->getAttributes($str);
-	$attrsNonsense = $class->getAttributes("some random string");
-
-	assertType('array<ReflectionAttribute<object>>', $attrsAll);
-	assertType('array<ReflectionAttribute<Issue5511\Abc>>', $attrsAbc1);
-	assertType('array<ReflectionAttribute<Issue5511\Abc>>', $attrsAbc2);
-	assertType('array<ReflectionAttribute<Issue5511\Abc>>', $attrsGCN);
-	assertType('array<ReflectionAttribute<object>>', $attrsCN);
-	assertType('array<ReflectionAttribute<object>>', $attrsStr);
-	assertType('array<ReflectionAttribute<some random string>>', $attrsNonsense);
+	$classAll = $reflectionClass->getAttributes();
+	$classAbc1 = $reflectionClass->getAttributes(Abc::class);
+	$classAbc2 = $reflectionClass->getAttributes(Abc::class, \ReflectionAttribute::IS_INSTANCEOF);
+	$classGCN = $reflectionClass->getAttributes($genericClassName);
+	$classCN = $reflectionClass->getAttributes($className);
+	$classStr = $reflectionClass->getAttributes($str);
+	$classNonsense = $reflectionClass->getAttributes("some random string");
+
+	assertType('array<ReflectionAttribute<object>>', $classAll);
+	assertType('array<ReflectionAttribute<Issue5511\Abc>>', $classAbc1);
+	assertType('array<ReflectionAttribute<Issue5511\Abc>>', $classAbc2);
+	assertType('array<ReflectionAttribute<Issue5511\Abc>>', $classGCN);
+	assertType('array<ReflectionAttribute<object>>', $classCN);
+	assertType('array<ReflectionAttribute<object>>', $classStr);
+	assertType('array<ReflectionAttribute<some random string>>', $classNonsense);
+
+	$methodAll = $reflectionMethod->getAttributes();
+	$methodAbc = $reflectionMethod->getAttributes(Abc::class);
+	assertType('array<ReflectionAttribute<object>>', $methodAll);
+	assertType('array<ReflectionAttribute<Issue5511\Abc>>', $methodAbc);
+
+	$paramAll = $reflectionParameter->getAttributes();
+	$paramAbc = $reflectionParameter->getAttributes(Abc::class);
+	assertType('array<ReflectionAttribute<object>>', $paramAll);
+	assertType('array<ReflectionAttribute<Issue5511\Abc>>', $paramAbc);
+
+	$propAll = $reflectionProperty->getAttributes();
+	$propAbc = $reflectionProperty->getAttributes(Abc::class);
+	assertType('array<ReflectionAttribute<object>>', $propAll);
+	assertType('array<ReflectionAttribute<Issue5511\Abc>>', $propAbc);
+
+	$constAll = $reflectionClassConstant->getAttributes();
+	$constAbc = $reflectionClassConstant->getAttributes(Abc::class);
+	assertType('array<ReflectionAttribute<object>>', $constAll);
+	assertType('array<ReflectionAttribute<Issue5511\Abc>>', $constAbc);
+
+	$funcAll = $reflectionFunction->getAttributes();
+	$funcAbc = $reflectionFunction->getAttributes(Abc::class);
+	assertType('array<ReflectionAttribute<object>>', $funcAll);
+	assertType('array<ReflectionAttribute<Issue5511\Abc>>', $funcAbc);
 }
 
 /**