More service converted to #[AutowiredService] attribute usage

Author: ondrejmirtes

conf/config.neon

@@ -216,22 +216,6 @@ extensions:
 	validateIgnoredErrors: PHPStan\DependencyInjection\ValidateIgnoredErrorsExtension
 	validateExcludePaths: PHPStan\DependencyInjection\ValidateExcludePathsExtension
 
-rules:
-	- PHPStan\Rules\Debug\DebugScopeRule
-	- PHPStan\Rules\Debug\DumpPhpDocTypeRule
-	- PHPStan\Rules\Debug\DumpTypeRule
-	- PHPStan\Rules\Debug\FileAssertRule
-	- PHPStan\Rules\RestrictedUsage\RestrictedClassConstantUsageRule
-	- PHPStan\Rules\RestrictedUsage\RestrictedFunctionUsageRule
-	- PHPStan\Rules\RestrictedUsage\RestrictedFunctionCallableUsageRule
-	- PHPStan\Rules\RestrictedUsage\RestrictedMethodUsageRule
-	- PHPStan\Rules\RestrictedUsage\RestrictedMethodCallableUsageRule
-	- PHPStan\Rules\RestrictedUsage\RestrictedPropertyUsageRule
-	- PHPStan\Rules\RestrictedUsage\RestrictedStaticMethodUsageRule
-	- PHPStan\Rules\RestrictedUsage\RestrictedStaticMethodCallableUsageRule
-	- PHPStan\Rules\RestrictedUsage\RestrictedStaticPropertyUsageRule
-	- PHPStan\Rules\RestrictedUsage\RestrictedUsageOfDeprecatedStringCastRule
-
 conditionalTags:
 	PHPStan\Rules\Exceptions\MissingCheckedExceptionInFunctionThrowsRule:
 		phpstan.rules.rule: %exceptions.check.missingCheckedExceptionInThrows%

src/DependencyInjection/AutowiredAttributeServicesExtension.php

@@ -5,6 +5,8 @@
 use Nette\DI\CompilerExtension;
 use olvlvl\ComposerAttributeCollector\Attributes;
 use PHPStan\Broker\BrokerFactory;
+use PHPStan\Rules\LazyRegistry;
+use PHPStan\Rules\Rule;
 use PHPStan\Type\DynamicFunctionReturnTypeExtension;
 use ReflectionClass;
 
@@ -19,6 +21,7 @@ public function loadConfiguration(): void
 
 		$interfaceToTag = [
 			DynamicFunctionReturnTypeExtension::class => BrokerFactory::DYNAMIC_FUNCTION_RETURN_TYPE_EXTENSION_TAG,
+			Rule::class => LazyRegistry::RULE_TAG,
 		];
 
 		foreach ($autowiredServiceClasses as $class) {

src/Rules/Debug/DebugScopeRule.php

@@ -5,6 +5,7 @@
 use PhpParser\Node;
 use PHPStan\Analyser\MutatingScope;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredService;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
@@ -16,6 +17,7 @@
 /**
  * @implements Rule<Node\Expr\FuncCall>
  */
+#[AutowiredService]
 final class DebugScopeRule implements Rule
 {
 

src/Rules/Debug/DumpPhpDocTypeRule.php

@@ -4,6 +4,7 @@
 
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredService;
 use PHPStan\PhpDocParser\Printer\Printer;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
@@ -15,6 +16,7 @@
 /**
  * @implements Rule<Node\Expr\FuncCall>
  */
+#[AutowiredService]
 final class DumpPhpDocTypeRule implements Rule
 {
 

src/Rules/Debug/DumpTypeRule.php

@@ -4,6 +4,7 @@
 
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredService;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
@@ -15,6 +16,7 @@
 /**
  * @implements Rule<Node\Expr\FuncCall>
  */
+#[AutowiredService]
 final class DumpTypeRule implements Rule
 {
 

src/Rules/Debug/FileAssertRule.php

@@ -5,6 +5,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr\StaticCall;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredService;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\IdentifierRuleError;
 use PHPStan\Rules\Rule;
@@ -18,6 +19,7 @@
 /**
  * @implements Rule<Node\Expr\FuncCall>
  */
+#[AutowiredService]
 final class FileAssertRule implements Rule
 {
 

src/Rules/RestrictedUsage/RestrictedClassConstantUsageRule.php

@@ -6,6 +6,7 @@
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Name;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredService;
 use PHPStan\DependencyInjection\Container;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
@@ -17,6 +18,7 @@
 /**
  * @implements Rule<Node\Expr\ClassConstFetch>
  */
+#[AutowiredService]
 final class RestrictedClassConstantUsageRule implements Rule
 {
 

src/Rules/RestrictedUsage/RestrictedFunctionCallableUsageRule.php

@@ -5,6 +5,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Name;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredService;
 use PHPStan\DependencyInjection\Container;
 use PHPStan\Node\FunctionCallableNode;
 use PHPStan\Reflection\ReflectionProvider;
@@ -14,6 +15,7 @@
 /**
  * @implements Rule<FunctionCallableNode>
  */
+#[AutowiredService]
 final class RestrictedFunctionCallableUsageRule implements Rule
 {
 

src/Rules/RestrictedUsage/RestrictedFunctionUsageRule.php

@@ -5,6 +5,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Name;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredService;
 use PHPStan\DependencyInjection\Container;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
@@ -13,6 +14,7 @@
 /**
  * @implements Rule<Node\Expr\FuncCall>
  */
+#[AutowiredService]
 final class RestrictedFunctionUsageRule implements Rule
 {
 

src/Rules/RestrictedUsage/RestrictedMethodCallableUsageRule.php

@@ -5,6 +5,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Identifier;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredService;
 use PHPStan\DependencyInjection\Container;
 use PHPStan\Node\MethodCallableNode;
 use PHPStan\Reflection\ReflectionProvider;
@@ -14,6 +15,7 @@
 /**
  * @implements Rule<MethodCallableNode>
  */
+#[AutowiredService]
 final class RestrictedMethodCallableUsageRule implements Rule
 {
 

src/Rules/RestrictedUsage/RestrictedMethodUsageRule.php

@@ -6,6 +6,7 @@
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Identifier;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredService;
 use PHPStan\DependencyInjection\Container;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
@@ -14,6 +15,7 @@
 /**
  * @implements Rule<MethodCall>
  */
+#[AutowiredService]
 final class RestrictedMethodUsageRule implements Rule
 {
 

src/Rules/RestrictedUsage/RestrictedPropertyUsageRule.php

@@ -5,6 +5,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Identifier;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredService;
 use PHPStan\DependencyInjection\Container;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
@@ -13,6 +14,7 @@
 /**
  * @implements Rule<Node\Expr\PropertyFetch>
  */
+#[AutowiredService]
 final class RestrictedPropertyUsageRule implements Rule
 {
 

src/Rules/RestrictedUsage/RestrictedStaticMethodCallableUsageRule.php

@@ -6,6 +6,7 @@
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Name;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredService;
 use PHPStan\DependencyInjection\Container;
 use PHPStan\Node\StaticMethodCallableNode;
 use PHPStan\Reflection\ReflectionProvider;
@@ -18,6 +19,7 @@
 /**
  * @implements Rule<StaticMethodCallableNode>
  */
+#[AutowiredService]
 final class RestrictedStaticMethodCallableUsageRule implements Rule
 {
 

src/Rules/RestrictedUsage/RestrictedStaticMethodUsageRule.php

@@ -6,6 +6,7 @@
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Name;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredService;
 use PHPStan\DependencyInjection\Container;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
@@ -17,6 +18,7 @@
 /**
  * @implements Rule<Node\Expr\StaticCall>
  */
+#[AutowiredService]
 final class RestrictedStaticMethodUsageRule implements Rule
 {
 

src/Rules/RestrictedUsage/RestrictedStaticPropertyUsageRule.php

@@ -6,6 +6,7 @@
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Name;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredService;
 use PHPStan\DependencyInjection\Container;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
@@ -17,6 +18,7 @@
 /**
  * @implements Rule<Node\Expr\StaticPropertyFetch>
  */
+#[AutowiredService]
 final class RestrictedStaticPropertyUsageRule implements Rule
 {
 

src/Rules/RestrictedUsage/RestrictedUsageOfDeprecatedStringCastRule.php

@@ -5,6 +5,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr\Cast;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredService;
 use PHPStan\DependencyInjection\Container;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
@@ -13,6 +14,7 @@
 /**
  * @implements Rule<Cast\String_>
  */
+#[AutowiredService]
 final class RestrictedUsageOfDeprecatedStringCastRule implements Rule
 {