More #[RegisteredRule]

Author: ondrejmirtes

conf/config.level0.neon

@@ -16,196 +16,9 @@ conditionalTags:
 		phpstan.rules.rule: %featureToggles.newStaticInAbstractClassStaticMethod%
 
 services:
-	-
-		class: PHPStan\Rules\Classes\ExistingClassInClassExtendsRule
-		tags:
-			- phpstan.rules.rule
-		arguments:
-			discoveringSymbolsTip: %tips.discoveringSymbols%
-
-	-
-		class: PHPStan\Rules\Classes\ExistingClassesInClassImplementsRule
-		tags:
-			- phpstan.rules.rule
-		arguments:
-			discoveringSymbolsTip: %tips.discoveringSymbols%
-
-	-
-		class: PHPStan\Rules\Classes\ExistingClassesInEnumImplementsRule
-		tags:
-			- phpstan.rules.rule
-		arguments:
-			discoveringSymbolsTip: %tips.discoveringSymbols%
-
-	-
-		class: PHPStan\Rules\Classes\ExistingClassInInstanceOfRule
-		tags:
-			- phpstan.rules.rule
-		arguments:
-			checkClassCaseSensitivity: %checkClassCaseSensitivity%
-			discoveringSymbolsTip: %tips.discoveringSymbols%
-
-	-
-		class: PHPStan\Rules\Classes\ExistingClassesInInterfaceExtendsRule
-		tags:
-			- phpstan.rules.rule
-		arguments:
-			discoveringSymbolsTip: %tips.discoveringSymbols%
-
-	-
-		class: PHPStan\Rules\Classes\ExistingClassInTraitUseRule
-		tags:
-			- phpstan.rules.rule
-		arguments:
-			discoveringSymbolsTip: %tips.discoveringSymbols%
-
-	-
-		class: PHPStan\Rules\Classes\InstantiationRule
-		tags:
-			- phpstan.rules.rule
-		arguments:
-			discoveringSymbolsTip: %tips.discoveringSymbols%
-
-	-
-		class: PHPStan\Rules\Exceptions\CaughtExceptionExistenceRule
-		tags:
-			- phpstan.rules.rule
-		arguments:
-			checkClassCaseSensitivity: %checkClassCaseSensitivity%
-			discoveringSymbolsTip: %tips.discoveringSymbols%
-
-	-
-		class: PHPStan\Rules\Functions\CallToNonExistentFunctionRule
-		tags:
-			- phpstan.rules.rule
-		arguments:
-			checkFunctionNameCase: %checkFunctionNameCase%
-			discoveringSymbolsTip: %tips.discoveringSymbols%
-
 	-
 		class: PHPStan\Rules\Classes\NewStaticInAbstractClassStaticMethodRule
 
-	-
-		class: PHPStan\Rules\Constants\OverridingConstantRule
-		arguments:
-			checkPhpDocMethodSignatures: %checkPhpDocMethodSignatures%
-		tags:
-			- phpstan.rules.rule
-
-	-
-		class: PHPStan\Rules\Methods\OverridingMethodRule
-		arguments:
-			checkPhpDocMethodSignatures: %checkPhpDocMethodSignatures%
-			checkMissingOverrideMethodAttribute: %checkMissingOverrideMethodAttribute%
-		tags:
-			- phpstan.rules.rule
-
-
-	-
-		class: PHPStan\Rules\Missing\MissingReturnRule
-		arguments:
-			checkExplicitMixedMissingReturn: %checkExplicitMixedMissingReturn%
-			checkPhpDocMissingReturn: %checkPhpDocMissingReturn%
-		tags:
-			- phpstan.rules.rule
-
-	-
-		class: PHPStan\Rules\Namespaces\ExistingNamesInGroupUseRule
-		tags:
-			- phpstan.rules.rule
-		arguments:
-			checkFunctionNameCase: %checkFunctionNameCase%
-			discoveringSymbolsTip: %tips.discoveringSymbols%
-
-	-
-		class: PHPStan\Rules\Namespaces\ExistingNamesInUseRule
-		tags:
-			- phpstan.rules.rule
-		arguments:
-			checkFunctionNameCase: %checkFunctionNameCase%
-			discoveringSymbolsTip: %tips.discoveringSymbols%
-
-	-
-		class: PHPStan\Rules\Properties\AccessPropertiesRule
-		tags:
-			- phpstan.rules.rule
-
-	-
-		class: PHPStan\Rules\Properties\AccessStaticPropertiesRule
-		tags:
-			- phpstan.rules.rule
-		arguments:
-			discoveringSymbolsTip: %tips.discoveringSymbols%
-
-	-
-		class: PHPStan\Rules\Properties\ExistingClassesInPropertiesRule
-		tags:
-			- phpstan.rules.rule
-		arguments:
-			checkClassCaseSensitivity: %checkClassCaseSensitivity%
-			checkThisOnly: %checkThisOnly%
-			discoveringSymbolsTip: %tips.discoveringSymbols%
-
-	-
-		class: PHPStan\Rules\Functions\FunctionCallableRule
-		arguments:
-			checkFunctionNameCase: %checkFunctionNameCase%
-			reportMaybes: %reportMaybes%
-		tags:
-			- phpstan.rules.rule
-
-	-
-		class: PHPStan\Rules\Properties\OverridingPropertyRule
-		arguments:
-			checkPhpDocMethodSignatures: %checkPhpDocMethodSignatures%
-			reportMaybes: %reportMaybesInPropertyPhpDocTypes%
-		tags:
-			- phpstan.rules.rule
-
-	-
-		class: PHPStan\Rules\Properties\SetPropertyHookParameterRule
-		arguments:
-			checkPhpDocMethodSignatures: %checkPhpDocMethodSignatures%
-			checkMissingTypehints: %checkMissingTypehints%
-		tags:
-			- phpstan.rules.rule
-
-	-
-		class: PHPStan\Rules\Properties\WritingToReadOnlyPropertiesRule
-		arguments:
-			checkThisOnly: %checkThisOnly%
-		tags:
-			- phpstan.rules.rule
-
-	-
-		class: PHPStan\Rules\Properties\ReadingWriteOnlyPropertiesRule
-		arguments:
-			checkThisOnly: %checkThisOnly%
-		tags:
-			- phpstan.rules.rule
-
-	-
-		class: PHPStan\Rules\Variables\CompactVariablesRule
-		arguments:
-			checkMaybeUndefinedVariables: %checkMaybeUndefinedVariables%
-		tags:
-			- phpstan.rules.rule
-
-	-
-		class: PHPStan\Rules\Variables\DefinedVariableRule
-		arguments:
-			cliArgumentsVariablesRegistered: %cliArgumentsVariablesRegistered%
-			checkMaybeUndefinedVariables: %checkMaybeUndefinedVariables%
-		tags:
-			- phpstan.rules.rule
-
-	-
-		class: PHPStan\Rules\Keywords\RequireFileExistsRule
-		arguments:
-			currentWorkingDirectory: %currentWorkingDirectory%
-		tags:
-			- phpstan.rules.rule
-
 	-
 		class: PHPStan\Rules\InternalTag\RestrictedInternalClassConstantUsageExtension
 

src/DependencyInjection/AutowiredAttributeServicesExtension.php

@@ -65,10 +65,12 @@ public function loadConfiguration(): void
 				continue;
 			}
 
-			$builder->addDefinition(null)
+			$definition = $builder->addDefinition(null)
 				->setFactory($class->name)
 				->setAutowired($class->name)
 				->addTag(LazyRegistry::RULE_TAG);
+
+			$this->processParameters($class->name, $definition, $autowiredParameters);
 		}
 	}
 

src/Rules/Classes/ExistingClassInClassExtendsRule.php

@@ -4,6 +4,8 @@
 
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredParameter;
+use PHPStan\DependencyInjection\RegisteredRule;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\ClassNameCheck;
 use PHPStan\Rules\ClassNameNodePair;
@@ -15,12 +17,14 @@
 /**
  * @implements Rule<Node\Stmt\Class_>
  */
+#[RegisteredRule(level: 0)]
 final class ExistingClassInClassExtendsRule implements Rule
 {
 
 	public function __construct(
 		private ClassNameCheck $classCheck,
 		private ReflectionProvider $reflectionProvider,
+		#[AutowiredParameter(ref: '%tips.discoveringSymbols%')]
 		private bool $discoveringSymbolsTip,
 	)
 	{

src/Rules/Classes/ExistingClassInInstanceOfRule.php

@@ -5,6 +5,8 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr\Instanceof_;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredParameter;
+use PHPStan\DependencyInjection\RegisteredRule;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\ClassNameCheck;
 use PHPStan\Rules\ClassNameNodePair;
@@ -20,13 +22,16 @@
 /**
  * @implements Rule<Node\Expr\Instanceof_>
  */
+#[RegisteredRule(level: 0)]
 final class ExistingClassInInstanceOfRule implements Rule
 {
 
 	public function __construct(
 		private ReflectionProvider $reflectionProvider,
 		private ClassNameCheck $classCheck,
+		#[AutowiredParameter]
 		private bool $checkClassCaseSensitivity,
+		#[AutowiredParameter(ref: '%tips.discoveringSymbols%')]
 		private bool $discoveringSymbolsTip,
 	)
 	{

src/Rules/Classes/ExistingClassInTraitUseRule.php

@@ -4,6 +4,8 @@
 
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredParameter;
+use PHPStan\DependencyInjection\RegisteredRule;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\ClassNameCheck;
 use PHPStan\Rules\ClassNameNodePair;
@@ -17,12 +19,14 @@
 /**
  * @implements Rule<Node\Stmt\TraitUse>
  */
+#[RegisteredRule(level: 0)]
 final class ExistingClassInTraitUseRule implements Rule
 {
 
 	public function __construct(
 		private ClassNameCheck $classCheck,
 		private ReflectionProvider $reflectionProvider,
+		#[AutowiredParameter(ref: '%tips.discoveringSymbols%')]
 		private bool $discoveringSymbolsTip,
 	)
 	{

src/Rules/Classes/ExistingClassesInClassImplementsRule.php

@@ -4,6 +4,8 @@
 
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredParameter;
+use PHPStan\DependencyInjection\RegisteredRule;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\ClassNameCheck;
 use PHPStan\Rules\ClassNameNodePair;
@@ -16,12 +18,14 @@
 /**
  * @implements Rule<Node\Stmt\Class_>
  */
+#[RegisteredRule(level: 0)]
 final class ExistingClassesInClassImplementsRule implements Rule
 {
 
 	public function __construct(
 		private ClassNameCheck $classCheck,
 		private ReflectionProvider $reflectionProvider,
+		#[AutowiredParameter(ref: '%tips.discoveringSymbols%')]
 		private bool $discoveringSymbolsTip,
 	)
 	{

src/Rules/Classes/ExistingClassesInEnumImplementsRule.php

@@ -4,6 +4,8 @@
 
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredParameter;
+use PHPStan\DependencyInjection\RegisteredRule;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\ClassNameCheck;
 use PHPStan\Rules\ClassNameNodePair;
@@ -16,12 +18,14 @@
 /**
  * @implements Rule<Node\Stmt\Enum_>
  */
+#[RegisteredRule(level: 0)]
 final class ExistingClassesInEnumImplementsRule implements Rule
 {
 
 	public function __construct(
 		private ClassNameCheck $classCheck,
 		private ReflectionProvider $reflectionProvider,
+		#[AutowiredParameter(ref: '%tips.discoveringSymbols%')]
 		private bool $discoveringSymbolsTip,
 	)
 	{

src/Rules/Classes/ExistingClassesInInterfaceExtendsRule.php

@@ -4,6 +4,8 @@
 
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredParameter;
+use PHPStan\DependencyInjection\RegisteredRule;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\ClassNameCheck;
 use PHPStan\Rules\ClassNameNodePair;
@@ -16,12 +18,14 @@
 /**
  * @implements Rule<Node\Stmt\Interface_>
  */
+#[RegisteredRule(level: 0)]
 final class ExistingClassesInInterfaceExtendsRule implements Rule
 {
 
 	public function __construct(
 		private ClassNameCheck $classCheck,
 		private ReflectionProvider $reflectionProvider,
+		#[AutowiredParameter(ref: '%tips.discoveringSymbols%')]
 		private bool $discoveringSymbolsTip,
 	)
 	{

src/Rules/Classes/InstantiationRule.php

@@ -5,7 +5,9 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr\New_;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredParameter;
 use PHPStan\DependencyInjection\Container;
+use PHPStan\DependencyInjection\RegisteredRule;
 use PHPStan\Internal\SprintfHelper;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\ParametersAcceptorSelector;
@@ -32,6 +34,7 @@
 /**
  * @implements Rule<Node\Expr\New_>
  */
+#[RegisteredRule(level: 0)]
 final class InstantiationRule implements Rule
 {
 
@@ -40,6 +43,7 @@ public function __construct(
 		private ReflectionProvider $reflectionProvider,
 		private FunctionCallParametersCheck $check,
 		private ClassNameCheck $classCheck,
+		#[AutowiredParameter(ref: '%tips.discoveringSymbols%')]
 		private bool $discoveringSymbolsTip,
 	)
 	{