Converted rules in neons in conf/ to RegisteredRule attributes

Author: ondrejmirtes

conf/config.level0.neon

@@ -1,107 +1,6 @@
 parameters:
 	customRulesetUsed: false
 
-rules:
-	- PHPStan\Rules\Api\ApiInstanceofTypeRule
-	- PHPStan\Rules\Api\ApiInstantiationRule
-	- PHPStan\Rules\Api\ApiClassConstFetchRule
-	- PHPStan\Rules\Api\ApiClassExtendsRule
-	- PHPStan\Rules\Api\ApiClassImplementsRule
-	- PHPStan\Rules\Api\ApiInterfaceExtendsRule
-	- PHPStan\Rules\Api\ApiMethodCallRule
-	- PHPStan\Rules\Api\ApiStaticCallRule
-	- PHPStan\Rules\Api\ApiTraitUseRule
-	- PHPStan\Rules\Api\GetTemplateTypeRule
-	- PHPStan\Rules\Api\NodeConnectingVisitorAttributesRule
-	- PHPStan\Rules\Api\OldPhpParser4ClassRule
-	- PHPStan\Rules\Api\PhpStanNamespaceIn3rdPartyPackageRule
-	- PHPStan\Rules\Api\RuntimeReflectionInstantiationRule
-	- PHPStan\Rules\Api\RuntimeReflectionFunctionRule
-	- PHPStan\Rules\Arrays\DuplicateKeysInLiteralArraysRule
-	- PHPStan\Rules\Arrays\OffsetAccessWithoutDimForReadingRule
-	- PHPStan\Rules\Cast\UnsetCastRule
-	- PHPStan\Rules\Classes\AllowedSubTypesRule
-	- PHPStan\Rules\Classes\ClassAttributesRule
-	- PHPStan\Rules\Classes\ClassConstantAttributesRule
-	- PHPStan\Rules\Classes\ClassConstantRule
-	- PHPStan\Rules\Classes\DuplicateDeclarationRule
-	- PHPStan\Rules\Classes\EnumSanityRule
-	- PHPStan\Rules\Classes\InstantiationCallableRule
-	- PHPStan\Rules\Classes\InvalidPromotedPropertiesRule
-	- PHPStan\Rules\Classes\LocalTypeAliasesRule
-	- PHPStan\Rules\Classes\LocalTypeTraitUseAliasesRule
-	- PHPStan\Rules\Classes\LocalTypeTraitAliasesRule
-	- PHPStan\Rules\Classes\NewStaticRule
-	- PHPStan\Rules\Classes\NonClassAttributeClassRule
-	- PHPStan\Rules\Classes\ReadOnlyClassRule
-	- PHPStan\Rules\Classes\TraitAttributeClassRule
-	- PHPStan\Rules\Constants\ClassAsClassConstantRule
-	- PHPStan\Rules\Constants\DynamicClassConstantFetchRule
-	- PHPStan\Rules\Constants\FinalConstantRule
-	- PHPStan\Rules\Constants\MagicConstantContextRule
-	- PHPStan\Rules\Constants\NativeTypedClassConstantRule
-	- PHPStan\Rules\Constants\FinalPrivateConstantRule
-	- PHPStan\Rules\EnumCases\EnumCaseAttributesRule
-	- PHPStan\Rules\Exceptions\NoncapturingCatchRule
-	- PHPStan\Rules\Exceptions\ThrowExpressionRule
-	- PHPStan\Rules\Functions\ArrowFunctionAttributesRule
-	- PHPStan\Rules\Functions\ArrowFunctionReturnNullsafeByRefRule
-	- PHPStan\Rules\Functions\ClosureAttributesRule
-	- PHPStan\Rules\Functions\DefineParametersRule
-	- PHPStan\Rules\Functions\ExistingClassesInArrowFunctionTypehintsRule
-	- PHPStan\Rules\Functions\CallToFunctionParametersRule
-	- PHPStan\Rules\Functions\ExistingClassesInClosureTypehintsRule
-	- PHPStan\Rules\Functions\ExistingClassesInTypehintsRule
-	- PHPStan\Rules\Functions\FunctionAttributesRule
-	- PHPStan\Rules\Functions\InnerFunctionRule
-	- PHPStan\Rules\Functions\InvalidLexicalVariablesInClosureUseRule
-	- PHPStan\Rules\Functions\ParamAttributesRule
-	- PHPStan\Rules\Functions\PrintfArrayParametersRule
-	- PHPStan\Rules\Functions\PrintfParametersRule
-	- PHPStan\Rules\Functions\RedefinedParametersRule
-	- PHPStan\Rules\Functions\ReturnNullsafeByRefRule
-	- PHPStan\Rules\Ignore\IgnoreParseErrorRule
-	- PHPStan\Rules\Functions\VariadicParametersDeclarationRule
-	- PHPStan\Rules\Keywords\ContinueBreakInLoopRule
-	- PHPStan\Rules\Keywords\DeclareStrictTypesRule
-	- PHPStan\Rules\Methods\AbstractMethodInNonAbstractClassRule
-	- PHPStan\Rules\Methods\AbstractPrivateMethodRule
-	- PHPStan\Rules\Methods\CallMethodsRule
-	- PHPStan\Rules\Methods\CallStaticMethodsRule
-	- PHPStan\Rules\Methods\ConsistentConstructorRule
-	- PHPStan\Rules\Methods\ConstructorReturnTypeRule
-	- PHPStan\Rules\Methods\ExistingClassesInTypehintsRule
-	- PHPStan\Rules\Methods\FinalPrivateMethodRule
-	- PHPStan\Rules\Methods\MethodCallableRule
-	- PHPStan\Rules\Methods\MethodVisibilityInInterfaceRule
-	- PHPStan\Rules\Methods\MissingMagicSerializationMethodsRule
-	- PHPStan\Rules\Methods\MissingMethodImplementationRule
-	- PHPStan\Rules\Methods\MethodAttributesRule
-	- PHPStan\Rules\Methods\StaticMethodCallableRule
-	- PHPStan\Rules\Names\UsedNamesRule
-	- PHPStan\Rules\Operators\InvalidAssignVarRule
-	- PHPStan\Rules\Operators\InvalidIncDecOperationRule
-	- PHPStan\Rules\Properties\AccessPropertiesInAssignRule
-	- PHPStan\Rules\Properties\AccessStaticPropertiesInAssignRule
-	- PHPStan\Rules\Properties\ExistingClassesInPropertyHookTypehintsRule
-	- PHPStan\Rules\Properties\InvalidCallablePropertyTypeRule
-	- PHPStan\Rules\Properties\MissingReadOnlyPropertyAssignRule
-	- PHPStan\Rules\Properties\MissingReadOnlyByPhpDocPropertyAssignRule
-	- PHPStan\Rules\Properties\PropertiesInInterfaceRule
-	- PHPStan\Rules\Properties\PropertyAssignRefRule
-	- PHPStan\Rules\Properties\PropertyAttributesRule
-	- PHPStan\Rules\Properties\PropertyHookAttributesRule
-	- PHPStan\Rules\Properties\PropertyInClassRule
-	- PHPStan\Rules\Properties\ReadOnlyPropertyRule
-	- PHPStan\Rules\Properties\ReadOnlyByPhpDocPropertyRule
-	- PHPStan\Rules\Regexp\RegularExpressionPatternRule
-	- PHPStan\Rules\Traits\ConflictingTraitConstantsRule
-	- PHPStan\Rules\Traits\ConstantsInTraitsRule
-	- PHPStan\Rules\Traits\TraitAttributesRule
-	- PHPStan\Rules\Types\InvalidTypesInUnionRule
-	- PHPStan\Rules\Variables\UnsetRule
-	- PHPStan\Rules\Whitespace\FileWhitespaceRule
-
 autowiredAttributeServices:
 	# registers rules with #[RegisteredRule] attribute
 	level: 0

conf/config.level1.neon

@@ -7,13 +7,6 @@ parameters:
 	reportMagicMethods: true
 	reportMagicProperties: true
 
-rules:
-	- PHPStan\Rules\Classes\UnusedConstructorParametersRule
-	- PHPStan\Rules\Functions\UnusedClosureUsesRule
-	- PHPStan\Rules\Variables\EmptyRule
-	- PHPStan\Rules\Variables\IssetRule
-	- PHPStan\Rules\Variables\NullCoalesceRule
-
 autowiredAttributeServices:
 	# registers rules with #[RegisteredRule] attribute
 	level: 1

conf/config.level2.neon

@@ -6,67 +6,6 @@ parameters:
 	checkThisOnly: false
 	checkPhpDocMissingReturn: true
 
-rules:
-	- PHPStan\Rules\Cast\EchoRule
-	- PHPStan\Rules\Cast\InvalidCastRule
-	- PHPStan\Rules\Cast\InvalidPartOfEncapsedStringRule
-	- PHPStan\Rules\Cast\PrintRule
-	- PHPStan\Rules\Classes\AccessPrivateConstantThroughStaticRule
-	- PHPStan\Rules\Classes\MethodTagRule
-	- PHPStan\Rules\Classes\MethodTagTraitRule
-	- PHPStan\Rules\Classes\MethodTagTraitUseRule
-	- PHPStan\Rules\Classes\PropertyTagRule
-	- PHPStan\Rules\Classes\PropertyTagTraitRule
-	- PHPStan\Rules\Classes\PropertyTagTraitUseRule
-	- PHPStan\Rules\Classes\MixinTraitRule
-	- PHPStan\Rules\Classes\MixinTraitUseRule
-	- PHPStan\Rules\Comparison\UsageOfVoidMatchExpressionRule
-	- PHPStan\Rules\Constants\ValueAssignedToClassConstantRule
-	- PHPStan\Rules\Functions\IncompatibleDefaultParameterTypeRule
-	- PHPStan\Rules\Functions\IncompatibleArrowFunctionDefaultParameterTypeRule
-	- PHPStan\Rules\Functions\IncompatibleClosureDefaultParameterTypeRule
-	- PHPStan\Rules\Generics\ClassAncestorsRule
-	- PHPStan\Rules\Generics\ClassTemplateTypeRule
-	- PHPStan\Rules\Generics\EnumAncestorsRule
-	- PHPStan\Rules\Generics\EnumTemplateTypeRule
-	- PHPStan\Rules\Generics\FunctionTemplateTypeRule
-	- PHPStan\Rules\Generics\FunctionSignatureVarianceRule
-	- PHPStan\Rules\Generics\InterfaceAncestorsRule
-	- PHPStan\Rules\Generics\InterfaceTemplateTypeRule
-	- PHPStan\Rules\Generics\MethodTemplateTypeRule
-	- PHPStan\Rules\Generics\MethodTagTemplateTypeRule
-	- PHPStan\Rules\Generics\MethodTagTemplateTypeTraitRule
-	- PHPStan\Rules\Generics\MethodSignatureVarianceRule
-	- PHPStan\Rules\Generics\PropertyVarianceRule
-	- PHPStan\Rules\Generics\TraitTemplateTypeRule
-	- PHPStan\Rules\Generics\UsedTraitsRule
-	- PHPStan\Rules\Methods\CallPrivateMethodThroughStaticRule
-	- PHPStan\Rules\Methods\IncompatibleDefaultParameterTypeRule
-	- PHPStan\Rules\Operators\InvalidBinaryOperationRule
-	- PHPStan\Rules\Operators\InvalidComparisonOperationRule
-	- PHPStan\Rules\Operators\InvalidUnaryOperationRule
-	- PHPStan\Rules\PhpDoc\FunctionConditionalReturnTypeRule
-	- PHPStan\Rules\PhpDoc\MethodConditionalReturnTypeRule
-	- PHPStan\Rules\PhpDoc\FunctionAssertRule
-	- PHPStan\Rules\PhpDoc\MethodAssertRule
-	- PHPStan\Rules\PhpDoc\IncompatibleSelfOutTypeRule
-	- PHPStan\Rules\PhpDoc\IncompatibleClassConstantPhpDocTypeRule
-	- PHPStan\Rules\PhpDoc\IncompatiblePhpDocTypeRule
-	- PHPStan\Rules\PhpDoc\IncompatiblePropertyHookPhpDocTypeRule
-	- PHPStan\Rules\PhpDoc\IncompatiblePropertyPhpDocTypeRule
-	- PHPStan\Rules\PhpDoc\InvalidThrowsPhpDocValueRule
-	- PHPStan\Rules\PhpDoc\IncompatibleParamImmediatelyInvokedCallableRule
-	- PHPStan\Rules\PhpDoc\VarTagChangedExpressionTypeRule
-	- PHPStan\Rules\PhpDoc\WrongVariableNameInVarTagRule
-	- PHPStan\Rules\Properties\AccessPrivatePropertyThroughStaticRule
-	- PHPStan\Rules\Classes\RequireImplementsRule
-	- PHPStan\Rules\Classes\RequireExtendsRule
-	- PHPStan\Rules\PhpDoc\RequireImplementsDefinitionClassRule
-	- PHPStan\Rules\PhpDoc\RequireExtendsDefinitionClassRule
-	- PHPStan\Rules\PhpDoc\RequireExtendsDefinitionTraitRule
-	- PHPStan\Rules\Pure\PureFunctionRule
-	- PHPStan\Rules\Pure\PureMethodRule
-
 autowiredAttributeServices:
 	# registers rules with #[RegisteredRule] attribute
 	level: 2

conf/config.level3.neon

@@ -1,32 +1,6 @@
 includes:
 	- config.level2.neon
 
-rules:
-	- PHPStan\Rules\Arrays\ArrayDestructuringRule
-	- PHPStan\Rules\Arrays\ArrayUnpackingRule
-	- PHPStan\Rules\Arrays\IterableInForeachRule
-	- PHPStan\Rules\Arrays\OffsetAccessAssignmentRule
-	- PHPStan\Rules\Arrays\OffsetAccessAssignOpRule
-	- PHPStan\Rules\Arrays\OffsetAccessValueAssignmentRule
-	- PHPStan\Rules\Arrays\UnpackIterableInArrayRule
-	- PHPStan\Rules\Exceptions\ThrowExprTypeRule
-	- PHPStan\Rules\Functions\ArrowFunctionReturnTypeRule
-	- PHPStan\Rules\Functions\ClosureReturnTypeRule
-	- PHPStan\Rules\Functions\ReturnTypeRule
-	- PHPStan\Rules\Generators\YieldTypeRule
-	- PHPStan\Rules\Methods\ReturnTypeRule
-	- PHPStan\Rules\Properties\DefaultValueTypesAssignedToPropertiesRule
-	- PHPStan\Rules\Properties\GetNonVirtualPropertyHookReadRule
-	- PHPStan\Rules\Properties\ReadOnlyPropertyAssignRule
-	- PHPStan\Rules\Properties\ReadOnlyByPhpDocPropertyAssignRule
-	- PHPStan\Rules\Properties\ReadOnlyPropertyAssignRefRule
-	- PHPStan\Rules\Properties\ReadOnlyByPhpDocPropertyAssignRefRule
-	- PHPStan\Rules\Properties\SetNonVirtualPropertyHookAssignRule
-	- PHPStan\Rules\Properties\TypesAssignedToPropertiesRule
-	- PHPStan\Rules\Variables\ParameterOutAssignedTypeRule
-	- PHPStan\Rules\Variables\ParameterOutExecutionEndTypeRule
-	- PHPStan\Rules\Variables\VariableCloningRule
-
 autowiredAttributeServices:
 	# registers rules with #[RegisteredRule] attribute
 	level: 3

conf/config.level4.neon

@@ -1,31 +1,6 @@
 includes:
 	- config.level3.neon
 
-rules:
-	- PHPStan\Rules\Arrays\DeadForeachRule
-	- PHPStan\Rules\DeadCode\CallToConstructorStatementWithoutImpurePointsRule
-	- PHPStan\Rules\DeadCode\CallToFunctionStatementWithoutImpurePointsRule
-	- PHPStan\Rules\DeadCode\CallToMethodStatementWithoutImpurePointsRule
-	- PHPStan\Rules\DeadCode\CallToStaticMethodStatementWithoutImpurePointsRule
-	- PHPStan\Rules\DeadCode\NoopRule
-	- PHPStan\Rules\DeadCode\UnreachableStatementRule
-	- PHPStan\Rules\DeadCode\UnusedPrivateConstantRule
-	- PHPStan\Rules\DeadCode\UnusedPrivateMethodRule
-	- PHPStan\Rules\Exceptions\OverwrittenExitPointByFinallyRule
-	- PHPStan\Rules\Functions\CallToFunctionStatementWithoutSideEffectsRule
-	- PHPStan\Rules\Functions\UselessFunctionReturnValueRule
-	- PHPStan\Rules\Methods\CallToConstructorStatementWithoutSideEffectsRule
-	- PHPStan\Rules\Methods\CallToMethodStatementWithoutSideEffectsRule
-	- PHPStan\Rules\Methods\CallToStaticMethodStatementWithoutSideEffectsRule
-	- PHPStan\Rules\Methods\NullsafeMethodCallRule
-	- PHPStan\Rules\TooWideTypehints\TooWideArrowFunctionReturnTypehintRule
-	- PHPStan\Rules\TooWideTypehints\TooWideClosureReturnTypehintRule
-	- PHPStan\Rules\TooWideTypehints\TooWideFunctionReturnTypehintRule
-	- PHPStan\Rules\TooWideTypehints\TooWideFunctionParameterOutTypeRule
-	- PHPStan\Rules\TooWideTypehints\TooWideMethodParameterOutTypeRule
-	- PHPStan\Rules\TooWideTypehints\TooWidePropertyTypeRule
-	- PHPStan\Rules\Traits\NotAnalysedTraitRule
-
 autowiredAttributeServices:
 	# registers rules with #[RegisteredRule] attribute
 	level: 4

conf/config.level5.neon

@@ -9,14 +9,6 @@ conditionalTags:
 	PHPStan\Rules\Functions\ParameterCastableToNumberRule:
 		phpstan.rules.rule: %featureToggles.checkParameterCastableToNumberFunctions%
 
-rules:
-	- PHPStan\Rules\DateTimeInstantiationRule
-	- PHPStan\Rules\Functions\CallUserFuncRule
-	- PHPStan\Rules\Functions\ParameterCastableToStringRule
-	- PHPStan\Rules\Functions\ImplodeParameterCastableToStringRule
-	- PHPStan\Rules\Functions\SortParameterCastableToStringRule
-	- PHPStan\Rules\Regexp\RegularExpressionQuotingRule
-
 autowiredAttributeServices:
 	# registers rules with #[RegisteredRule] attribute
 	level: 5

conf/config.level6.neon

@@ -5,15 +5,6 @@ parameters:
 	checkMissingVarTagTypehint: true
 	checkMissingTypehints: true
 
-rules:
-	- PHPStan\Rules\Constants\MissingClassConstantTypehintRule
-	- PHPStan\Rules\Functions\MissingFunctionParameterTypehintRule
-	- PHPStan\Rules\Functions\MissingFunctionReturnTypehintRule
-	- PHPStan\Rules\Methods\MissingMethodParameterTypehintRule
-	- PHPStan\Rules\Methods\MissingMethodReturnTypehintRule
-	- PHPStan\Rules\Methods\MissingMethodSelfOutTypeRule
-	- PHPStan\Rules\Properties\MissingPropertyTypehintRule
-
 autowiredAttributeServices:
 	# registers rules with #[RegisteredRule] attribute
 	level: 6

src/Rules/Api/ApiClassConstFetchRule.php

@@ -4,6 +4,7 @@
 
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\RegisteredRule;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
@@ -14,6 +15,7 @@
 /**
  * @implements Rule<Node\Expr\ClassConstFetch>
  */
+#[RegisteredRule(level: 0)]
 final class ApiClassConstFetchRule implements Rule
 {
 

src/Rules/Api/ApiClassExtendsRule.php

@@ -6,6 +6,7 @@
 use PhpParser\Node\Stmt\Class_;
 use PHPStan\Analyser\MutatingScope;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\RegisteredRule;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
@@ -15,6 +16,7 @@
 /**
  * @implements Rule<Class_>
  */
+#[RegisteredRule(level: 0)]
 final class ApiClassExtendsRule implements Rule
 {
 

src/Rules/Api/ApiClassImplementsRule.php

@@ -5,6 +5,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Stmt\Class_;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\RegisteredRule;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\IdentifierRuleError;
 use PHPStan\Rules\Rule;
@@ -17,6 +18,7 @@
 /**
  * @implements Rule<Class_>
  */
+#[RegisteredRule(level: 0)]
 final class ApiClassImplementsRule implements Rule
 {
 

src/Rules/Api/ApiInstanceofTypeRule.php

@@ -5,6 +5,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr\Instanceof_;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\RegisteredRule;
 use PHPStan\Parser\TypeTraverserInstanceofVisitor;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
@@ -51,6 +52,7 @@
 /**
  * @implements Rule<Instanceof_>
  */
+#[RegisteredRule(level: 0)]
 final class ApiInstanceofTypeRule implements Rule
 {
 

src/Rules/Api/ApiInstantiationRule.php

@@ -4,6 +4,7 @@
 
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\RegisteredRule;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
@@ -13,6 +14,7 @@
 /**
  * @implements Rule<Node\Expr\New_>
  */
+#[RegisteredRule(level: 0)]
 final class ApiInstantiationRule implements Rule
 {
 

src/Rules/Api/ApiInterfaceExtendsRule.php

@@ -5,6 +5,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Stmt\Interface_;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\RegisteredRule;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\IdentifierRuleError;
 use PHPStan\Rules\Rule;
@@ -17,6 +18,7 @@
 /**
  * @implements Rule<Interface_>
  */
+#[RegisteredRule(level: 0)]
 final class ApiInterfaceExtendsRule implements Rule
 {
 

src/Rules/Api/ApiMethodCallRule.php

@@ -4,6 +4,7 @@
 
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\RegisteredRule;
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
@@ -14,6 +15,7 @@
 /**
  * @implements Rule<Node\Expr\MethodCall>
  */
+#[RegisteredRule(level: 0)]
 final class ApiMethodCallRule implements Rule
 {