Skip to content

Commit 05f63cd

Browse files
committed
Um, skip 0 tests?
When we call `skip(1, ...)`, we get output like this: ``` 7: Test timeout computed to be: 1500 7: 1..1 7: ok 1 # skip DISABLE_IPV6_TESTS 7: ok 2 - NdbGetInAddr 7: # 1 tests planned but 2 executed 1/1 Test mysql#7: NdbGetInAddr-t ...................***Failed 0.00 sec 0% tests passed, 1 tests failed out of 1 ``` That is, the test suite thinks we ran more tests than we planned, which is its own failure. `skip(0, ...)` doesn't actually print the message or say anything was skipped, but it results in a passing message: ``` 7: Test command: /home/patrick/src/mysql-server/build/runtime_output_directory/NdbGetInAddr-t 7: Test timeout computed to be: 1500 7: 1..1 7: ok 1 - NdbGetInAddr 1/1 Test mysql#7: NdbGetInAddr-t ................... Passed 0.00 sec ``` For posterity, here is the command to run just that one test: ```bash DISABLE_IPV6_TESTS=1 DISABLE_TMPFILE_TESTS=1 make test ARGS="-R ^NdbGetIn -VV" ```
1 parent 20c6fa8 commit 05f63cd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

storage/ndb/src/common/portlib/NdbTCP.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,7 @@ TAPTEST(NdbGetInAddr)
500500
{
501501
if (getenv("DISABLE_IPV6_TESTS")) {
502502
// fails when ipv6 is present but disabled
503-
skip(1, "DISABLE_IPV6_TESTS");
503+
skip(0, "DISABLE_IPV6_TESTS");
504504
return 1;
505505
}
506506

0 commit comments

Comments
 (0)