Merge pull request mysql#9 from planetscale/piki/container-names

Use `$semver-ps-$sha` container names

Author: piki

.buildkite/hooks/pre-command

@@ -0,0 +1,12 @@
+set -eu
+
+git log -25000 --format='%H' | sort > tmp-log
+git show-ref | grep tags/mysql-8 | sort > tmp-tags
+export CONTAINER_SEMVER=$(join tmp-log tmp-tags | sort -k2 | tail -1 | cut -d- -f2)
+echo "Semantic version = \"${CONTAINER_SEMVER}\""
+
+export CONTAINER_SHORT_SHA=$(git log -1 --pretty='%h')
+echo "Short SHA = \"${CONTAINER_SHORT_SHA}\""
+
+export CONTAINER_BRANCH_NAME=$(echo "$BUILDKITE_BRANCH" | sed -e 's/[\/:]/_/g')
+echo "Safe branch name = \"${CONTAINER_BRANCH_NAME}\""

.buildkite/pipeline.yml

@@ -33,7 +33,7 @@ steps:
       - docker-compose#v3.9.0:
           run: release
           push:
-            - "release:${REGISTRY}/branch/${IMAGE_NAME}:${BUILDKITE_BRANCH}-latest"
+            - "release:${REGISTRY}/branch/${IMAGE_NAME}:${CONTAINER_SEMVER}-ps-${CONTAINER_SHORT_SHA}-${CONTAINER_BRANCH_NAME}"
 
   - name: "Build runtime mysql-server container for main"
     label: ":docker: Build runtime main container"
@@ -47,4 +47,4 @@ steps:
       - docker-compose#v3.9.0:
           run: release
           push:
-            - "release:${REGISTRY}/main/${IMAGE_NAME}:${BUILDKITE_BRANCH}-latest"
+            - "release:${REGISTRY}/main/${IMAGE_NAME}:${CONTAINER_SEMVER}-ps-${CONTAINER_SHORT_SHA}"

_planetscale/docs/registry.md

@@ -12,6 +12,22 @@ aws --region us-east-1 ecr list-images --profile build --repository-name 'branch
 ```
 
 If necessary, log into the [`build` profile](https://github.com/planetscale/infra/blob/12ae46f94b7b9ad15b0b1ef00c94d544e590c42f/aws_config#L57-L61) first:
+
 ```
 aws sso login --profile build
 ```
+
+### Run images
+
+To run a MySQL container image locally, first log in if needed:
+
+```
+aws sso login
+aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 997601596833.dkr.ecr.us-east-1.amazonaws.com
+```
+
+And then run it:
+
+```
+docker run -it 997601596833.dkr.ecr.us-east-1.amazonaws.com/branch/mysql-server:8.0.28-ps-sha4567
+```

build.sh

@@ -27,7 +27,6 @@ cmake \
   -DWITH_NUMA=ON \
   .. && \
 make -j $(nproc) && \
-make test ARGS="-j $(nproc)" && \
 make package -j $(nproc)
 
 cp *.tar.gz /dist/