Merge branch 'axis_spanning_layout_object_xref_yref_bug' of https://github.com/zfoltz/plotly.py into axis_spanning_layout_object_xref_yref_bug

Author: zfoltz

.circleci/config.yml

@@ -52,3 +52,6 @@ doc/check-or-enforce-order.py
 packages/javascript/jupyterlab-plotly/lib/
 packages/python/plotly/jupyterlab_plotly/labextension/
 packages/python/plotly/jupyterlab_plotly/nbextension/index.js*
+
+test/percy/*.html
+test/percy/pandas2/*.html

.gitignore

@@ -2,6 +2,11 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## [UNRELEASED]
+
+### Fixed
+  - Fixed another compatibility issue with Pandas 2.0, just affecting `px.*(line_close=True)` [[#4190](https://github.com/plotly/plotly.py/pull/4190)]
+
 ## [5.14.1] - 2023-04-05
 
 ### Fixed

CHANGELOG.md

@@ -109,42 +109,42 @@ If you are running this notebook live, click to [open the output directory](./im
 
 plotly.py can output figures to several raster image formats including **PNG**, ...
 
-```python
+~~~python
 fig.write_image("images/fig1.png")
-```
+~~~
 
 **JPEG**, ...
 
-```python
+~~~python
 fig.write_image("images/fig1.jpeg")
-```
+~~~
 
 and **WebP**
 
-```python
+~~~python
 fig.write_image("images/fig1.webp")
-```
+~~~
 
 #### Vector Formats: SVG and PDF...
 
 
 plotly.py can also output figures in several vector formats including **SVG**, ...
 
-```python
+~~~python
 fig.write_image("images/fig1.svg")
-```
+~~~
 
 **PDF**, ...
 
-```python
+~~~python
 fig.write_image("images/fig1.pdf")
-```
+~~~
 
 and **EPS** (requires the poppler library)
 
-```python
+~~~python
 fig.write_image("images/fig1.eps")
-```
+~~~
 
 **Note:** It is important to note that any figures containing WebGL traces (i.e. of type `scattergl`, `heatmapgl`, `contourgl`, `scatter3d`, `surface`, `mesh3d`, `scatterpolargl`, `cone`, `streamtube`, `splom`, or `parcoords`) that are exported in a vector format will include encapsulated rasters, instead of vectors, for some parts of the image.
 
@@ -199,14 +199,14 @@ Image(img_bytes)
 If `kaleido` is installed, it will automatically be used to perform image export.  If it is not installed, plotly.py will attempt to use `orca` instead. The `engine` argument to the `to_image` and `write_image` functions can be used to override this default behavior.
 
 Here is an example of specifying that orca should be used:
-```python
+~~~python
 fig.to_image(format="png", engine="orca")
-```
+~~~
 
 And, here is an example of specifying that Kaleido should be used:
-```python
+~~~python
 fig.to_image(format="png", engine="kaleido")
-```
+~~~
 
 <!-- #endregion -->
 

doc/python/static-image-export.md

@@ -4067,12 +4067,10 @@ def _process_multiple_axis_spanning_shapes(
                 # however, in the case of a single plot, xref and yref MAY not be
                 # specified, IF they are not specified we specify them here so the following routines can work
                 # (they need to append " domain" to xref or yref). If they are specified, we leave them alone.
-                if self.layout[layout_obj][-1].xref == None:
+                if self.layout[layout_obj][-1].xref is None:
                     self.layout[layout_obj][-1].update(xref="x")
-                # self.layout[layout_obj][-1].update(xref="x")
-                if self.layout[layout_obj][-1].yref == None:
+                if self.layout[layout_obj][-1].yref is None:
                     self.layout[layout_obj][-1].update(yref="y")
-                # self.layout[layout_obj][-1].update(yref='y')
             new_layout_objs = tuple(
                 filter(
                     lambda x: x is not None,

packages/python/plotly/plotly/basedatatypes.py

@@ -268,7 +268,7 @@ def make_trace_kwargs(args, trace_spec, trace_data, mapping_labels, sizeref):
         fit information to be used for trendlines
     """
     if "line_close" in args and args["line_close"]:
-        trace_data = trace_data.append(trace_data.iloc[0])
+        trace_data = pd.concat([trace_data, trace_data.iloc[:1]])
     trace_patch = trace_spec.trace_patch.copy() or {}
     fit_results = None
     hover_header = ""

packages/python/plotly/plotly/express/_core.py

@@ -23,8 +23,18 @@ def open_axes(self, ax, props):
             dict(type="y", scale="y", ticks=10),
         ]
         self.scales = [
-            dict(name="x", domain=props["xlim"], type="linear", range="width",),
-            dict(name="y", domain=props["ylim"], type="linear", range="height",),
+            dict(
+                name="x",
+                domain=props["xlim"],
+                type="linear",
+                range="width",
+            ),
+            dict(
+                name="y",
+                domain=props["ylim"],
+                type="linear",
+                range="height",
+            ),
         ]
 
     def draw_line(self, data, coordinates, style, label, mplobj=None):
@@ -103,7 +113,7 @@ def __init__(self, renderer):
 
     def html(self):
         """Build the HTML representation for IPython."""
-        id = random.randint(0, 2 ** 16)
+        id = random.randint(0, 2**16)
         html = '<div id="vis%d"></div>' % id
         html += "<script>\n"
         html += VEGA_TEMPLATE % (json.dumps(self.specification), id)

packages/python/plotly/plotly/matplotlylib/mplexporter/renderers/vega_renderer.py

@@ -146,8 +146,8 @@ def test_path():
 
 
 def test_Figure():
-    """ if the fig is not associated with a canvas, FakeRenderer shall
-    not fail. """
+    """if the fig is not associated with a canvas, FakeRenderer shall
+    not fail."""
     fig = plt.Figure()
     ax = fig.add_subplot(111)
     ax.add_patch(plt.Circle((0, 0), 1))