fix wasm feature gating (#122)

* update ci workflow - expect build fail

* typo

* fix workflow

* gate Plot::show on wasm targets

* mutually exclusive wasm and kaleio

* update changelog

* update workflow

* clippy

Author: mfreeborn

.github/workflows/ci.yml

@@ -36,8 +36,15 @@ jobs:
       - uses: dtolnay/rust-toolchain@stable
         with:
           components: clippy
-      - run: cargo clippy -- -D warnings
-      - run: cd ${{ github.workspace }}/examples && cargo clippy -- -D warnings
+          targets: wasm32-unknown-unknown
+      # lint the main library workspace excluding the wasm feature
+      - run: cargo clippy --features plotly_ndarray,plotly_image,kaleido -- -D warnings
+      # lint the plotly library with wasm enabled
+      - run: cargo clippy --package plotly --features wasm --target wasm32-unknown-unknown -- -D warnings
+      # lint the non-wasm examples
+      - run: cd ${{ github.workspace }}/examples && cargo clippy --workspace --exclude "wasm*" -- -D warnings
+      # lint the wasm examples
+      - run: cd ${{ github.workspace }}/examples && cargo clippy --target wasm32-unknown-unknown --package "wasm*"
 
   test:
     name: Tests
@@ -49,7 +56,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: dtolnay/rust-toolchain@stable
-      - run: cargo test --features=plotly_ndarray,kaleido
+      - run: cargo test --features plotly_ndarray,plotly_image,kaleido
 
   code-coverage:
     name: Code Coverage
@@ -60,15 +67,16 @@ jobs:
         with:
           components: llvm-tools-preview
       - uses: taiki-e/install-action@cargo-llvm-cov
-      - run: cargo llvm-cov --workspace --features=plotly_ndarray,plotly_image,kaleido --lcov --output-path lcov.info
+      # we are skipping anything to do with wasm here
+      - run: cargo llvm-cov --workspace --features plotly_ndarray,plotly_image,kaleido --lcov --output-path lcov.info
       - uses: codecov/codecov-action@v3
 
   build_examples:
     name: Build Examples
     strategy:
       fail-fast: false
       matrix:
-        example: [  # missing jupyter and wasm-yew-minimal
+        example: [  # missing jupyter
           3d_charts,
           basic_charts,
           custom_controls,
@@ -86,4 +94,18 @@ jobs:
       - uses: actions/checkout@v3
       - uses: dtolnay/rust-toolchain@stable
       - run: cd ${{ github.workspace }}/examples/${{ matrix.example }} && cargo build
+  
+  build_wasm_examples:
+    name: Build Wasm Examples
+    strategy:
+      fail-fast: false
+      matrix:
+        example: [wasm-yew-minimal]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: dtolnay/rust-toolchain@stable
+        with:
+          targets: wasm32-unknown-unknown
+      - run: cd ${{ github.workspace }}/examples/${{ matrix.example }} && cargo build --target wasm32-unknown-unknown
 

CHANGELOG.md

@@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.8.3] - 2022-11-04
+### Fixed
+- [[#122](https://github.com/igiagkiozis/plotly/pull/122)] Compilation error for the `wasm` feature.
+
 ## [0.8.2] - 2022-11-03
 ### Added
 - [[#110](https://github.com/igiagkiozis/plotly/pull/110)] `LegendGroupTitle` to existing traces.

plotly/src/bindings.rs

@@ -28,9 +28,7 @@ pub async fn new_plot(id: &str, plot: &Plot) {
     // This will only fail if the Rust Plotly library has produced
     // plotly-incompatible JSON. An error here should have been handled by the
     // library, rather than down here.
-    new_plot_(id, &plot_obj)
-        .await
-        .expect("Error plotting chart");
+    new_plot_(id, plot_obj).await.expect("Error plotting chart");
 }
 
 /// A wrapper around the plotly.js [react](https://plotly.com/javascript/plotlyjs-function-reference/#react)
@@ -45,5 +43,5 @@ pub async fn react(id: &str, plot: &Plot) {
     // This will only fail if the Rust Plotly library has produced
     // plotly-incompatible JSON. An error here should have been handled by the
     // library, rather than down here.
-    react_(id, &plot_obj).await.expect("Error plotting chart");
+    react_(id, plot_obj).await.expect("Error plotting chart");
 }

plotly/src/lib.rs

@@ -6,6 +6,11 @@ extern crate askama;
 extern crate rand;
 extern crate serde;
 
+#[cfg(all(feature = "kaleido", feature = "wasm"))]
+compile_error!(
+    r#"The "kaleido" and "wasm" features are mutually exclusive and cannot be activated at the same time. Please disable one or the other."#
+);
+
 #[cfg(feature = "plotly_ndarray")]
 pub mod ndarray;
 #[cfg(feature = "plotly_ndarray")]

plotly/src/plot.rs

@@ -247,6 +247,7 @@ impl Plot {
     ///
     /// The HTML file is saved in a temp file, from which it is read and
     /// displayed by the browser.
+    #[cfg(not(target_family = "wasm"))]
     pub fn show(&self) {
         use std::env;
 
@@ -405,6 +406,7 @@ impl Plot {
         tmpl.render().unwrap()
     }
 
+    #[cfg(not(target_family = "wasm"))]
     fn render_static(&self, format: ImageFormat, width: usize, height: usize) -> String {
         let tmpl = StaticPlotTemplate {
             plot: self,

plotly/src/private.rs

@@ -108,11 +108,7 @@ where
     T: Clone,
 {
     let mut traces: Vec<Vec<T>> = Vec::new();
-    let dim_index = if array_traces == ArrayTraces::OverColumns {
-        1
-    } else {
-        0
-    } as usize;
+    let dim_index = usize::from(array_traces == ArrayTraces::OverColumns);
     let traces_count = traces_matrix.shape()[dim_index];
     let get_trace = |index| {
         if array_traces == ArrayTraces::OverColumns {