Skip to content

Commit cc00eb2

Browse files
ngxsonpockers21
authored andcommitted
clip : improve projector naming (ggml-org#13118)
* clip : improve projector naming * no more kv has_llava_projector * rm unused kv * rm more unused
1 parent 4b6575c commit cc00eb2

File tree

3 files changed

+235
-306
lines changed

3 files changed

+235
-306
lines changed

examples/llava/clip-impl.h

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,15 @@
1717
#define KEY_FTYPE "general.file_type"
1818
#define KEY_NAME "general.name"
1919
#define KEY_DESCRIPTION "general.description"
20-
#define KEY_HAS_TEXT_ENC "clip.has_text_encoder"
21-
#define KEY_HAS_VIS_ENC "clip.has_vision_encoder"
22-
#define KEY_HAS_LLAVA_PROJ "clip.has_llava_projector"
23-
#define KEY_HAS_MINICPMV_PROJ "clip.has_minicpmv_projector"
24-
#define KEY_HAS_GLM_PROJ "clip.has_glm_projector"
2520
#define KEY_MINICPMV_VERSION "clip.minicpmv_version"
26-
#define KEY_HAS_QWEN2VL_MERGER "clip.has_qwen2vl_merger"
2721
#define KEY_USE_GELU "clip.use_gelu"
2822
#define KEY_USE_SILU "clip.use_silu"
29-
#define KEY_N_EMBD "clip.%s.embedding_length"
30-
#define KEY_N_FF "clip.%s.feed_forward_length"
31-
#define KEY_N_BLOCK "clip.%s.block_count"
32-
#define KEY_N_HEAD "clip.%s.attention.head_count"
33-
#define KEY_LAYER_NORM_EPS "clip.%s.attention.layer_norm_epsilon"
34-
#define KEY_PROJ_DIM "clip.%s.projection_dim"
35-
#define KEY_TOKENS "tokenizer.ggml.tokens"
23+
#define KEY_N_EMBD "clip.vision.embedding_length"
24+
#define KEY_N_FF "clip.vision.feed_forward_length"
25+
#define KEY_N_BLOCK "clip.vision.block_count"
26+
#define KEY_N_HEAD "clip.vision.attention.head_count"
27+
#define KEY_LAYER_NORM_EPS "clip.vision.attention.layer_norm_epsilon"
28+
#define KEY_PROJ_DIM "clip.vision.projection_dim"
3629
#define KEY_IMAGE_SIZE "clip.vision.image_size"
3730
#define KEY_PATCH_SIZE "clip.vision.patch_size"
3831
#define KEY_IMAGE_MEAN "clip.vision.image_mean"
@@ -96,9 +89,9 @@ enum projector_type {
9689
PROJECTOR_TYPE_MLP_NORM,
9790
PROJECTOR_TYPE_LDP,
9891
PROJECTOR_TYPE_LDPV2,
99-
PROJECTOR_TYPE_RESAMPLER,
92+
PROJECTOR_TYPE_MINICPMV,
10093
PROJECTOR_TYPE_GLM_EDGE,
101-
PROJECTOR_TYPE_MERGER,
94+
PROJECTOR_TYPE_QWEN2VL,
10295
PROJECTOR_TYPE_GEMMA3,
10396
PROJECTOR_TYPE_IDEFICS3,
10497
PROJECTOR_TYPE_PIXTRAL,
@@ -109,9 +102,9 @@ static std::map<projector_type, std::string> PROJECTOR_TYPE_NAMES = {
109102
{ PROJECTOR_TYPE_MLP, "mlp" },
110103
{ PROJECTOR_TYPE_LDP, "ldp" },
111104
{ PROJECTOR_TYPE_LDPV2, "ldpv2"},
112-
{ PROJECTOR_TYPE_RESAMPLER, "resampler"},
105+
{ PROJECTOR_TYPE_MINICPMV, "resampler"},
113106
{ PROJECTOR_TYPE_GLM_EDGE, "adapter"},
114-
{ PROJECTOR_TYPE_MERGER, "qwen2vl_merger"},
107+
{ PROJECTOR_TYPE_QWEN2VL, "qwen2vl_merger"},
115108
{ PROJECTOR_TYPE_GEMMA3, "gemma3"},
116109
{ PROJECTOR_TYPE_IDEFICS3, "idefics3"},
117110
{ PROJECTOR_TYPE_PIXTRAL, "pixtral"},

0 commit comments

Comments
 (0)