Fix warnings introduced in Xcode 14.1 (#1388)

* Fix warnings introduced in Xcode 14.1

* wip

Author: stephencelis

Examples/VoiceMemos/VoiceMemos/AudioRecorderClient/LiveAudioRecorderClient.swift

@@ -79,9 +79,10 @@ private actor AudioRecorder {
       }
     }
 
-    guard let action = try await stream.first(where: { @Sendable _ in true })
-    else { throw CancellationError() }
-    return action
+    for try await didFinish in stream {
+      return didFinish
+    }
+    throw CancellationError()
   }
 }
 

Sources/ComposableArchitecture/Internal/TaskCancellableValue.swift

@@ -2,9 +2,9 @@ extension Task where Failure == Error {
   var cancellableValue: Success {
     get async throws {
       try await withTaskCancellationHandler {
-        self.cancel()
-      } operation: {
         try await self.value
+      } onCancel: {
+        self.cancel()
       }
     }
   }
@@ -15,9 +15,9 @@ extension Task where Failure == Never {
   var cancellableValue: Success {
     get async {
       await withTaskCancellationHandler {
-        self.cancel()
-      } operation: {
         await self.value
+      } onCancel: {
+        self.cancel()
       }
     }
   }

Sources/ComposableArchitecture/Store.swift

@@ -409,13 +409,13 @@ public final class Store<State, Action> {
         var index = tasks.wrappedValue.startIndex
         while index < tasks.wrappedValue.endIndex {
           defer { index += 1 }
-          tasks.wrappedValue[index].cancel()
+          await tasks.wrappedValue[index].value
         }
-      } operation: {
+      } onCancel: {
         var index = tasks.wrappedValue.startIndex
         while index < tasks.wrappedValue.endIndex {
           defer { index += 1 }
-          await tasks.wrappedValue[index].value
+          tasks.wrappedValue[index].cancel()
         }
       }
     }

Sources/ComposableArchitecture/ViewStore.swift

@@ -252,9 +252,9 @@ public final class ViewStore<State, Action>: ObservableObject {
   public func send(_ action: Action, while predicate: @escaping (State) -> Bool) async {
     let task = self.send(action)
     await withTaskCancellationHandler {
-      task.rawValue?.cancel()
-    } operation: {
       await self.yield(while: predicate)
+    } onCancel: {
+      task.rawValue?.cancel()
     }
   }
 
@@ -274,9 +274,9 @@ public final class ViewStore<State, Action>: ObservableObject {
   ) async {
     let task = withAnimation(animation) { self.send(action) }
     await withTaskCancellationHandler {
-      task.rawValue?.cancel()
-    } operation: {
       await self.yield(while: predicate)
+    } onCancel: {
+      task.rawValue?.cancel()
     }
   }
 
@@ -296,8 +296,6 @@ public final class ViewStore<State, Action>: ObservableObject {
     } else {
       let cancellable = Box<AnyCancellable?>(wrappedValue: nil)
       try? await withTaskCancellationHandler {
-        cancellable.wrappedValue?.cancel()
-      } operation: {
         try Task.checkCancellation()
         try await withUnsafeThrowingContinuation {
           (continuation: UnsafeContinuation<Void, Error>) in
@@ -313,6 +311,8 @@ public final class ViewStore<State, Action>: ObservableObject {
               _ = cancellable
             }
         }
+      } onCancel: {
+        cancellable.wrappedValue?.cancel()
       }
     }
   }