Clean up skipInFlightEffects and write test on beahvior. (#2057)

Author: mbrandonw

Sources/ComposableArchitecture/TestStore.swift

@@ -2114,10 +2114,6 @@ extension TestStore {
       file: file,
       line: line
     )
-
-    for effect in self.reducer.inFlightEffects {
-      _ = EffectPublisher<Never, Never>.cancel(id: effect.id).sink { _ in }
-    }
     self.reducer.inFlightEffects = []
   }
 

Tests/ComposableArchitectureTests/TestStoreTests.swift

@@ -404,6 +404,33 @@ final class TestStoreTests: BaseTCATestCase {
       $0.date = now
     }
   }
+
+  func testEffectEmitAfterSkipInFlightEffects() async {
+    let mainQueue = DispatchQueue.test
+    enum Action: Equatable { case tap, response }
+    let store = TestStore(
+      initialState: 0,
+      reducer: Reduce<Int, Action> { state, action in
+        switch action {
+        case .tap:
+          return .run { send in
+            try await mainQueue.sleep(for: .seconds(1))
+            await send(.response)
+          }
+        case .response:
+          state = 42
+          return .none
+        }
+      }
+    )
+
+    await store.send(.tap)
+    await store.skipInFlightEffects()
+    await mainQueue.advance(by: .seconds(1))
+    await store.receive(.response) {
+      $0 = 42
+    }
+  }
 }
 
 private struct Client: DependencyKey {