refactor(forms): use a type guard to get rid of casts (angular#32541)

Use an explicit type guard when checking if a given object is of type AbstractControlOptions,
instead of a simple function returning a boolean value. This allows us to remove manual type
casting when using this function, relying instead on TypeScript to infer correct types.

PR Close angular#32541

Author: lazarljubenovic

packages/forms/src/model.ts

@@ -71,11 +71,7 @@ function _find(control: AbstractControl, path: Array<string|number>|string, deli
 
 function coerceToValidator(validatorOrOpts?: ValidatorFn|ValidatorFn[]|AbstractControlOptions|
                            null): ValidatorFn|null {
-  const validator =
-      (isOptionsObj(validatorOrOpts) ? (validatorOrOpts as AbstractControlOptions).validators :
-                                       validatorOrOpts) as ValidatorFn |
-      ValidatorFn[] | null;
-
+  const validator = isOptionsObj(validatorOrOpts) ? validatorOrOpts.validators : validatorOrOpts;
   return Array.isArray(validator) ? composeValidators(validator) : validator || null;
 }
 
@@ -84,10 +80,7 @@ function coerceToAsyncValidator(
     validatorOrOpts?: ValidatorFn|ValidatorFn[]|AbstractControlOptions|null): AsyncValidatorFn|
     null {
   const origAsyncValidator =
-      (isOptionsObj(validatorOrOpts) ? (validatorOrOpts as AbstractControlOptions).asyncValidators :
-                                       asyncValidator) as AsyncValidatorFn |
-      AsyncValidatorFn | null;
-
+      isOptionsObj(validatorOrOpts) ? validatorOrOpts.asyncValidators : asyncValidator;
   return Array.isArray(origAsyncValidator) ? composeAsyncValidators(origAsyncValidator) :
                                              origAsyncValidator || null;
 }
@@ -119,7 +112,7 @@ export interface AbstractControlOptions {
 
 
 function isOptionsObj(validatorOrOpts?: ValidatorFn|ValidatorFn[]|AbstractControlOptions|
-                      null): boolean {
+                      null): validatorOrOpts is AbstractControlOptions {
   return validatorOrOpts != null && !Array.isArray(validatorOrOpts) &&
       typeof validatorOrOpts === 'object';
 }
@@ -914,8 +907,8 @@ export abstract class AbstractControl {
 
   /** @internal */
   _setUpdateStrategy(opts?: ValidatorFn|ValidatorFn[]|AbstractControlOptions|null): void {
-    if (isOptionsObj(opts) && (opts as AbstractControlOptions).updateOn != null) {
-      this._updateOn = (opts as AbstractControlOptions).updateOn!;
+    if (isOptionsObj(opts) && opts.updateOn != null) {
+      this._updateOn = opts.updateOn!;
     }
   }