Skip to content

Commit 7831669

Browse files
Remove dllexport attribute on variable definition. (#20833)
It is unnecessary and seems to be confusing MinGW into thinking it is a definition with internal linkage. Fixes #20822 PiperOrigin-RevId: 740418802 Co-authored-by: Protobuf Team Bot <[email protected]>
1 parent da9cadc commit 7831669

15 files changed

+201
-268
lines changed

src/google/protobuf/any.pb.cc

Lines changed: 3 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/google/protobuf/api.pb.cc

Lines changed: 9 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/google/protobuf/compiler/cpp/message.cc

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4206,10 +4206,9 @@ void MessageGenerator::GenerateClassData(io::Printer* p) {
42064206
};
42074207
}
42084208
4209-
PROTOBUF_CONSTINIT$ dllexport_decl$
4210-
PROTOBUF_ATTRIBUTE_INIT_PRIORITY1 const $pbi$::ClassDataFull
4211-
$classname$_class_data_ =
4212-
$classname$::InternalGenerateClassData_();
4209+
PROTOBUF_CONSTINIT PROTOBUF_ATTRIBUTE_INIT_PRIORITY1 const
4210+
$pbi$::ClassDataFull $classname$_class_data_ =
4211+
$classname$::InternalGenerateClassData_();
42134212
42144213
const $pbi$::ClassData* $nonnull$ $classname$::GetClassData() const {
42154214
$pin_weak_descriptor$;

src/google/protobuf/compiler/java/java_features.pb.cc

Lines changed: 3 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/google/protobuf/compiler/plugin.pb.cc

Lines changed: 12 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/google/protobuf/cpp_features.pb.cc

Lines changed: 3 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)