Skip to content

Commit 6d065f8

Browse files
authored
Fixup onLog for null vm for non-stream (Root) context. (#58)
Signed-off-by: John Plevyak <[email protected]>
1 parent a21abb5 commit 6d065f8

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

WORKSPACE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
55

66
git_repository(
77
name = "proxy_wasm_cpp_sdk",
8-
commit = "aea22d74befc1bb34d2b8c35f0558e53ba5d1cd5",
8+
commit = "1b5f69ce1535b0c21f88c4af4ebf0ec51d255abe",
99
remote = "https://github.com/proxy-wasm/proxy-wasm-cpp-sdk",
1010
)
1111

include/proxy-wasm/context_interface.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,9 @@ struct RootInterface : public RootGrpcInterface {
179179
*/
180180
virtual bool onDone() = 0;
181181

182+
// Call for logging not associated with a stream lifecycle (e.g. logging only plugin).
183+
virtual void onLog() = 0;
184+
182185
/**
183186
* Call when no further stream calls will occur. This will cause the corresponding Context in the
184187
* VM to be deleted.

src/null/null_plugin.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,7 @@ void NullPlugin::onLog(uint64_t context_id) {
472472
registry_->proxy_on_log_(context_id);
473473
return;
474474
}
475-
getContext(context_id)->onLog();
475+
getContextBase(context_id)->onLog();
476476
}
477477

478478
uint64_t NullPlugin::onDone(uint64_t context_id) {

0 commit comments

Comments
 (0)