Skip to content

Commit a05b5b6

Browse files
authored
test: print Wasm engine names in test logs. (#254)
While there, sort them alphabetically. Signed-off-by: Piotr Sikora <[email protected]>
1 parent d9a9371 commit a05b5b6

File tree

4 files changed

+16
-13
lines changed

4 files changed

+16
-13
lines changed

test/exports_test.cc

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,10 @@
3030
namespace proxy_wasm {
3131
namespace {
3232

33-
auto test_values = testing::ValuesIn(getWasmEngines());
34-
35-
INSTANTIATE_TEST_SUITE_P(WasmEngines, TestVM, test_values);
33+
INSTANTIATE_TEST_SUITE_P(WasmEngines, TestVM, testing::ValuesIn(getWasmEngines()),
34+
[](const testing::TestParamInfo<std::string> &info) {
35+
return info.param;
36+
});
3637

3738
class TestContext : public ContextBase {
3839
public:

test/runtime_test.cc

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,10 @@
2929
namespace proxy_wasm {
3030
namespace {
3131

32-
auto test_values = testing::ValuesIn(getWasmEngines());
33-
34-
INSTANTIATE_TEST_SUITE_P(WasmEngines, TestVM, test_values);
32+
INSTANTIATE_TEST_SUITE_P(WasmEngines, TestVM, testing::ValuesIn(getWasmEngines()),
33+
[](const testing::TestParamInfo<std::string> &info) {
34+
return info.param;
35+
});
3536

3637
TEST_P(TestVM, Basic) {
3738
if (engine_ == "wamr") {

test/utility.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@ std::vector<std::string> getWasmEngines() {
2121
#if defined(PROXY_WASM_HOST_ENGINE_V8)
2222
"v8",
2323
#endif
24-
#if defined(PROXY_WASM_HOST_ENGINE_WAVM)
25-
"wavm",
24+
#if defined(PROXY_WASM_HOST_ENGINE_WAMR)
25+
"wamr",
2626
#endif
2727
#if defined(PROXY_WASM_HOST_ENGINE_WASMTIME)
2828
"wasmtime",
2929
#endif
30-
#if defined(PROXY_WASM_HOST_ENGINE_WAMR)
31-
"wamr",
30+
#if defined(PROXY_WASM_HOST_ENGINE_WAVM)
31+
"wavm",
3232
#endif
3333
""
3434
};

test/wasm_test.cc

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,10 @@
2020

2121
namespace proxy_wasm {
2222

23-
auto test_values = testing::ValuesIn(getWasmEngines());
24-
25-
INSTANTIATE_TEST_SUITE_P(WasmEngines, TestVM, test_values);
23+
INSTANTIATE_TEST_SUITE_P(WasmEngines, TestVM, testing::ValuesIn(getWasmEngines()),
24+
[](const testing::TestParamInfo<std::string> &info) {
25+
return info.param;
26+
});
2627

2728
// Fail callbacks only used for WasmVMs - not available for NullVM.
2829
TEST_P(TestVM, GetOrCreateThreadLocalWasmFailCallbacks) {

0 commit comments

Comments
 (0)