Skip to content

Allow access to status message from a child context. #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2021

Conversation

PiotrSikora
Copy link
Member

Previously, proxy_get_status() would return status message only when it was
called from the root context, which doesn't work when the effective context
is automatically changed to the calling context as part of the SDK.

With this change, status can be accessed from either root or child context.

Signed-off-by: Piotr Sikora [email protected]

Previously, proxy_get_status() would return status message only when it was
called from the root context, which doesn't work when the effective context
is automatically changed to the calling context as part of the SDK.

With this change, status can be accessed from either root or child context.

Signed-off-by: Piotr Sikora <[email protected]>
@PiotrSikora PiotrSikora requested a review from mathetake as a code owner May 28, 2021 07:52
Copy link
Contributor

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Just curious, is there any public code using get_status?)

@PiotrSikora
Copy link
Member Author

gRPC tests in Envoy (here and here). Currently, the only use case for it is to retrieve the contents of gRPC status message, although that's available as part of trailing metadata (grpc-message) anyway.

@PiotrSikora PiotrSikora merged commit 152fdb4 into proxy-wasm:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants