wamr: remove dependency on LLVM. #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're using WAMR in interpreter mode, without AOT and/or JIT, so the LLVM dependency wasn't used and it was unnecessarily built. This can be reverted once we add support for precompiled modules. Signed-off-by: Piotr Sikora <[email protected]>
mathetake
approved these changes
Jan 31, 2022
PiotrSikora
added a commit
to PiotrSikora/proxy-wasm-cpp-host
that referenced
this pull request
Feb 10, 2022
Following proxy-wasm#239, it builds fast enough. Signed-off-by: Piotr Sikora <[email protected]>
Merged
PiotrSikora
added a commit
that referenced
this pull request
Feb 17, 2022
Following #239, it builds fast enough. Signed-off-by: Piotr Sikora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WAMR is being used in an interpreter mode, without AOT and/or JIT,
so LLVM isn't needed, and it was previously unnecessarily built.
This can be reverted once we add support for precompiled modules.
Signed-off-by: Piotr Sikora [email protected]