Skip to content

wasmtime: update to v0.34.1. #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 18, 2022

Conversation

kfaseela
Copy link
Contributor

Signed-off-by: Faseela K [email protected]

Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, with 2 nits.

@@ -25,11 +28,6 @@ additional_flags = [
"--cfg=feature=\\\"cc\\\"",
]
buildrs_additional_deps = [
"@wasmtime__cc__1_0_72//:cc",
"@wasmtime__cc__1_0_73//:cc",
]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: trailing empty line.

Signed-off-by: Faseela K <[email protected]>
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@PiotrSikora PiotrSikora merged commit f2c162f into proxy-wasm:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants