Skip to content

Avoid thread-unsafe host integration call in terminate(). #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2022
Merged

Avoid thread-unsafe host integration call in terminate(). #271

merged 1 commit into from
Mar 1, 2022

Conversation

PiotrSikora
Copy link
Member

Signed-off-by: Piotr Sikora [email protected]

@PiotrSikora PiotrSikora requested a review from mathetake as a code owner March 1, 2022 10:20
@PiotrSikora
Copy link
Member Author

This passed before, because we didn't log trace-level host integration logs by default.

Found in #270 while changing the log level.

chaoqin-li1123
chaoqin-li1123 approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@chaoqin-li1123 chaoqin-li1123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@PiotrSikora PiotrSikora merged commit 6786024 into proxy-wasm:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathetake mathetake mathetake approved these changes

@chaoqin-li1123 chaoqin-li1123 chaoqin-li1123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PiotrSikora @mathetake @chaoqin-li1123