Skip to content

Fix the CI. #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2023
Merged

Fix the CI. #151

merged 4 commits into from
Apr 29, 2023

Conversation

martijneken
Copy link
Contributor

No description provided.

Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change ubuntu-latest to ubuntu-22.04 to avoid base image change silently breaking this in the future?

@martijneken
Copy link
Contributor Author

Could you change ubuntu-latest to ubuntu-22.04 to avoid base image change silently breaking this in the future?

Done, PTAL.

@martijneken
Copy link
Contributor Author

Can we auto-run testing workflows in this repo? Seems like proxy-wasm-cpp-host does that.

Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PiotrSikora PiotrSikora changed the title Fix proxy-wasm-cpp-sdk CI Fix the CI. Apr 28, 2023
@PiotrSikora
Copy link
Member

@mpwarres could you merge it? It looks that I don't have the permission to do that in this repo anymore.

@PiotrSikora
Copy link
Member

Can we auto-run testing workflows in this repo? Seems like proxy-wasm-cpp-host does that.

They are executed automatically, but only for people who contributed previously (this is a GitHub-wide policy to prevent abuse). Once this PR is merged, your other changes will trigger CI automatically.

@mpwarres mpwarres merged commit 97de5ab into proxy-wasm:master Apr 29, 2023
@martijneken martijneken deleted the fix-cpp-sdk-ci branch April 29, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants