Replies: 1 comment 1 reply
-
Fine with me: How about adding a new public write() method to MidiCommon which calls writeData |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I'm currently trying to write a class (extending from MidiCommon) that encapsulated the functionality of BLE Midi, Apple Midi and serial Midi.
The easiest way (in terms of sending) would have been to do sth. like this:
But unfortunately
AppleMidiServer::writeData
andMidiStreamOut
havewriteData
set up as a protected method meaning I can't call them as shown above.For
MidiBleServer::writeData
, surprisingly it is not protected. But still, for the other classes it creates great inconveniences for my use case.It would be nice if we could simply make that method public consistently. Sort of like the internal
Print
class haswrite
set up publicly.I would be willing to create a PR for this.
Beta Was this translation helpful? Give feedback.
All reactions