Merge pull request mybatis#358 from kazuki43zoo/polish-binding-package

Polish binding package classes

Author: emacarron

src/main/java/org/apache/ibatis/binding/MapperMethod.java

@@ -332,23 +332,22 @@ private String getParamNameFromAnnotation(Method method, int i, String paramName
       for (Object paramAnno : paramAnnos) {
         if (paramAnno instanceof Param) {
           paramName = ((Param) paramAnno).value();
+          break;
         }
       }
       return paramName;
     }
 
     private boolean hasNamedParams(Method method) {
-      boolean hasNamedParams = false;
       final Object[][] paramAnnos = method.getParameterAnnotations();
       for (Object[] paramAnno : paramAnnos) {
         for (Object aParamAnno : paramAnno) {
           if (aParamAnno instanceof Param) {
-            hasNamedParams = true;
-            break;
+            return true;
           }
         }
       }
-      return hasNamedParams;
+      return false;
     }
 
   }

src/main/java/org/apache/ibatis/binding/MapperProxyFactory.java

@@ -28,7 +28,7 @@
 public class MapperProxyFactory<T> {
 
   private final Class<T> mapperInterface;
-  private Map<Method, MapperMethod> methodCache = new ConcurrentHashMap<Method, MapperMethod>();
+  private final Map<Method, MapperMethod> methodCache = new ConcurrentHashMap<Method, MapperMethod>();
 
   public MapperProxyFactory(Class<T> mapperInterface) {
     this.mapperInterface = mapperInterface;

src/main/java/org/apache/ibatis/binding/MapperRegistry.java

@@ -33,7 +33,7 @@
  */
 public class MapperRegistry {
 
-  private Configuration config;
+  private final Configuration config;
   private final Map<Class<?>, MapperProxyFactory<?>> knownMappers = new HashMap<Class<?>, MapperProxyFactory<?>>();
 
   public MapperRegistry(Configuration config) {