React 18 + spago migrate #67
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenkis
force-pushed
the
switch-to-createroot
branch
2 times, most recently
from
e9466de to
b695607
Compare
alenkis
force-pushed
the
switch-to-createroot
branch
from
b695607 to
a521972
Compare
|
Is it ready to be merged ? |
|
@alenkis Thanks for the PR! I would rather wait until the change is merged into purescript-react, rather than relying on FFI. Also spago-next is very experimental and I definitely don't want to remove support for the old spago dhall configs yet. I'm closing this for now, but we can revisit the situation later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
React DOM
renderis no longer supported in React 18, but unfortunately react-dom doesn't implementcreateRootyet. This PR adds changes as proposed here: purescript-contrib/purescript-react-dom#29, and relies on FFI in the meantime.Migrating to
spago.yamlwas also necessary for myself to use my fork, would this be desirable to merge?