-
Notifications
You must be signed in to change notification settings - Fork 15
Several propositions #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the proposals.
|
At first I was talking about two modules in the same package, but now you got me thinking. Having both Yes, Basically |
Oh, and the last thing that I forgot to mention - both render :: ReactElement -> Element -> Effect Unit -> Effect (Maybe ReactComponent)
render = ...
render' :: ReactElement -> Element -> Effect (Maybe ReactComponent)
render' x y = render x y $ pure unit |
Here are some changes that I think could be beneficial for this library:
react-dom
andreact-dom/server
modules, I think it makes sense to have the same kind of separation on purescript level, too.renderToString
andrenderToStaticMarkup
effectful - these functions can have side effects, here you can find an example (callingcollect
, thentoString
, thenrenderToString
will result incss
being an empty string)spago
as a better alternative topsc-package
.Don't know about the last one, but first two are definitely breaking changes. What do you think about it? If you are ok with these changes, I will make a PR.
The text was updated successfully, but these errors were encountered: